[sylpheed:34254] Re: [Patch] Choose template from toolbar

Hiroyuki Yamamoto hiro-y at kcn.ne.jp
Tue Oct 19 10:40:53 JST 2010


On Fri, 15 Oct 2010 00:45:22 +0200
Dennis Schulmeister <sylpheed at windows3.de> wrote:

> First let me just say hello, as I'm new to sylpheed and new to this
> list. So I hope this is the right place to post a patch. :)
> The attached patch adds a new menu button the compose window's toolbar
> which lets the user quickly insert a template into a new message. If
> the button's menu is opened a template can be chosen. If the button is
> simply activated (without showing the menu) the first template is used
> instead.
> Also the patch slightly changes the behaviour of how a template is
> applied. Normaly a popup window lets the user decide whether to insert
> the template or to replace the entire message. IMHO this only makes
> sense if there's already some text which would be lost. If the user
> didn't enter a message yet, it should be safe to simply insert the
> template.

I think that in most cases, a signature text will be inserted before the
user starts editing.

> Please let me know if there are any issues with the patch. Thanks.

I haven't test your patch yet, but it seems good as far as I read it.

Hiroyuki Yamamoto <hiro-y at kcn.ne.jp>

More information about the Sylpheed mailing list