[sylpheed:32470] Re: [PATCH] Re: Sylpheed 2.5.0 released

[Hiroyuki Yamamoto]

Hello,

On Fri, 20 Jun 2008 11:34:39 +0200
Michael Schwendt <mschwendt at gmail.com> wrote:

> On Wed, 18 Jun 2008 17:45:57 +0900, Hiroyuki Yamamoto wrote:
> 
> > > > http://cvs.fedoraproject.org/viewcvs/devel/sylpheed/sylpheed-2.4.8-enchant.patch?rev=1.2&view=log
> > > 
> > > Would be nice to know from Hiroyuki if this issue is going to be
> > > fixed in the next development release.
> > > I don't think that keep patching the distribution packages is the
> > > way to go in this case.
> > 
> > I want to fix it. One problem is that if I apply this patch, it
> > will no longer compile with the older version of GtkSpell
> > (including my development environment). Can someone create a patch
> > which will work both old and new GtkSpell?
> 
> Attached patch is the straight-forward implementation that evaluates
> the GtkSpell version via pkg-config. It adds -laspell for 2.0.12
> and defines USE_ENCHANT for >= 2.0.13.
> 
> If you don't like the two compose_set_spell_lang_menu() functions,
> the changes can be wrapped with additional #if USE_ENCHANT
> conditionals, which would make it less readable then, though.

Thanks for the patch.
Applied to svn trunk with some modification. Please test it.

-- 
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp>