[sylpheed:32458] [PATCH] Re: Sylpheed 2.5.0 released

[Michael Schwendt]

On Wed, 18 Jun 2008 17:45:57 +0900, Hiroyuki Yamamoto wrote:

> > > http://cvs.fedoraproject.org/viewcvs/devel/sylpheed/sylpheed-2.4.8-enchant.patch?rev=1.2&view=log
> > 
> > Would be nice to know from Hiroyuki if this issue is going to be fixed
> > in the next development release.
> > I don't think that keep patching the distribution packages is the way
> > to go in this case.
> 
> I want to fix it. One problem is that if I apply this patch, it will no
> longer compile with the older version of GtkSpell (including my
> development environment). Can someone create a patch which will work
> both old and new GtkSpell?

Attached patch is the straight-forward implementation that evaluates
the GtkSpell version via pkg-config. It adds -laspell for 2.0.12
and defines USE_ENCHANT for >= 2.0.13.

If you don't like the two compose_set_spell_lang_menu() functions,
the changes can be wrapped with additional #if USE_ENCHANT conditionals,
which would make it less readable then, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sylpheed-2.5.0-enchant.patch
Type: application/octet-stream
Size: 4673 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20080620/6048719a/attachment.obj