[sylpheed:30956] Re: [UPDATED PATCH] Re: Re: [PATCH] Don't show main window on startup

[Hiroyuki Yamamoto]

Hello,

On Thu, 15 Feb 2007 15:30:29 -0200
Ricardo Nabinger Sanchez <rnsanchez at wait4.org> wrote:

> On Thu, 15 Feb 2007 13:22:39 +0900
> Hiroyuki Yamamoto <hiro-y at kcn.ne.jp> wrote:
> 
> > I think just calling gtk_window_iconify() before gtk_widget_show()
> > will be sufficient. Thus, the feature doesn't depend on whether the
> > tray icon is enabled or not.
> 
> Thanks for the review.
> 
> Using only gtk_window_iconify() introduced a misbehavior: if tray
> icon is enabled, Sylpheed won't show the main window (good), but will
> show a minimized window "button" is the task panel (bad), which will
> disappear after a cycle in the tray icon (show Sylpheed, hide
> Sylpheed, the minimized button is the task panel goes away).
> 
> So, I modified your suggestion in order to Sylpheed work as expected
> in both situations: with or without tray icon.  The attached patch is
> in sync with beta4 (svn r1548).
> 
> With this updated patch, it doesn't matter if you have tray icon
> enabled.  If you have, Sylpheed will show the tray icon and nothing
> more.  If there's no tray icon, then Sylpheed will show itself
> minimized instead of popping up a main window.
> 
> I'm using it here, made a lot of tests with and without tray icon,
> with and without the patch, and it's working fine.  It would be great
> to know if it works under different OSes and
> {desktop,window}-managers combinations.

I think you also should follow the prefs_common.minimize_to_tray
setting (just minimize it if this is FALSE).

-- 
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp>