[sylpheed:30961] Re: [UPDATED PATCH] Re: Re: [PATCH] Don't show main window on startup

[Ricardo Nabinger Sanchez]

On Fri, 16 Feb 2007 11:02:04 +0900
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp> wrote:

> > Using only gtk_window_iconify() introduced a misbehavior: if tray
> > icon is enabled, Sylpheed won't show the main window (good), but will
> > show a minimized window "button" is the task panel (bad), which will
> > disappear after a cycle in the tray icon (show Sylpheed, hide
> > Sylpheed, the minimized button is the task panel goes away).
> > 
> > So, I modified your suggestion in order to Sylpheed work as expected
> > in both situations: with or without tray icon.  The attached patch is
> > in sync with beta4 (svn r1548).
> > 
> > With this updated patch, it doesn't matter if you have tray icon
> > enabled.  If you have, Sylpheed will show the tray icon and nothing
> > more.  If there's no tray icon, then Sylpheed will show itself
> > minimized instead of popping up a main window.
> > 
> > I'm using it here, made a lot of tests with and without tray icon,
> > with and without the patch, and it's working fine.  It would be great
> > to know if it works under different OSes and
> > {desktop,window}-managers combinations.
> 
> I think you also should follow the prefs_common.minimize_to_tray
> setting (just minimize it if this is FALSE).

Could you please explain a bit further?

If I check both for minimize_to_tray and dont_show_mainwin_on_startup, the
user can enable the "Don't show main window on startup" and "Minimize to
tray", and end with a non-working "Don't ...".  Ie, Sylpheed won't start
minimized.

Also, I should rename it to "Start Sylpheed minimized" or "Minimize on
startup", to be more precise on what this proposed option really does.

I'll wait for your feedback so I can better understand your comment and make
the patch better.

Thanks in advance.  :)

-- 
Ricardo Nabinger Sanchez     <rnsanchez@{gmail.com,wait4.org}>
Powered by FreeBSD

  "Left to themselves, things tend to go from bad to worse."