[sylpheed:30954] [UPDATED PATCH] Re: Re: [PATCH] Don't show main window on startup

[Ricardo Nabinger Sanchez]

On Thu, 15 Feb 2007 13:22:39 +0900
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp> wrote:

> I think just calling gtk_window_iconify() before gtk_widget_show() will
> be sufficient. Thus, the feature doesn't depend on whether the tray
> icon is enabled or not.

Thanks for the review.

Using only gtk_window_iconify() introduced a misbehavior: if tray icon is
enabled, Sylpheed won't show the main window (good), but will show a
minimized window "button" is the task panel (bad), which will disappear after
a cycle in the tray icon (show Sylpheed, hide Sylpheed, the minimized button
is the task panel goes away).

So, I modified your suggestion in order to Sylpheed work as expected in both
situations: with or without tray icon.  The attached patch is in sync with
beta4 (svn r1548).

With this updated patch, it doesn't matter if you have tray icon enabled.  If
you have, Sylpheed will show the tray icon and nothing more.  If there's no
tray icon, then Sylpheed will show itself minimized instead of popping up a
main window.

I'm using it here, made a lot of tests with and without tray icon, with and
without the patch, and it's working fine.  It would be great to know if it
works under different OSes and {desktop,window}-managers combinations.

This time I won't sign the message.  :)

Regards.

-- 
Ricardo Nabinger Sanchez     <rnsanchez@{gmail.com,wait4.org}>
Powered by FreeBSD

  "Left to themselves, things tend to go from bad to worse."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dont_show_mainwin_on_startup_r1.diff
Type: text/x-diff
Size: 3199 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20070215/50ee6516/attachment.bin