[sylpheed:33489] Re: [PATCH] Gravatar support

[Hiroyuki Yamamoto]

Hello,

On Sat, 9 Jan 2010 18:25:59 +0100
Jan Stępień <jan at stepien.cc> wrote:

> I've created a patch for Sylpheed 3.0.0beta4 which allows to display a
> gravatar [1] of the sender of a message instead of showing his X-Face.
> It's based on bits found in update_check.c and headerview.c. It works
> but it requires quite a lot of touch ups, for instance
> 
>   * Caching gravatars locally
>   * Enabling/disabling gravatars fetching in settings
>   * Handling a situation when a gravatar isn't available due to a 404
>   * Offline state
>   * Portability
> 
> Please let me know what do you think about it. Do you find it useful?

Some comments with brief looking:

- This type of feature probably should be implemented as a plug-in
  (currently there is no plug-in APIs for these features, they must be
   implemented in the future)
- Sylpheed has internal MD5 routine (libsylph/md5.[ch]), so you don't
  have to depend on OpenSSL
- downloading_cb() must be surrounded by
  gdk_threads_enter()/gdk_threads_leave()
- g_assert() is overkill, g_return_if_fail() is better
- use g_snprintf() instead of g_sprintf()

-- 
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp>