[sylpheed:33486] Re: [PATCH] Gravatar support

[Tommy Reynolds]

Uttered Jan Stępień <jan at stepien.cc>, spoke thus:

> On Sun, 10 Jan 2010 16:37:52 +0100
> Antonio Ospite <ospite at studenti.unina.it> wrote:
> > On Sat, 9 Jan 2010 18:25:59 +0100
> > Jan Stępień <jan at stepien.cc> wrote:
> > > I've created a patch for Sylpheed 3.0.0beta4 which allows to display a
> > > gravatar [1] of the sender of a message instead of showing his X-Face.
> As you've noticed it's just an early version to see what will be the
> response of the Sylpheed community. The patch will surely need to be
> better integrated in order not to abuse compface and other existing
> features.
> > > It's based on bits found in update_check.c and headerview.c. It works
> > > but it requires quite a lot of touch ups, for instance
> > >   * Caching gravatars locally
> > >   * Enabling/disabling gravatars fetching in settings
> > >   * Handling a situation when a gravatar isn't available due to a 404
> > >   * Offline state
> > Could the latter be handled by downloading the image at receiving-time
> > (we are very likely online at that time), and providing a bulk
> > operation to get/refresh images for old mails? Trying a connection on
> > each headerview rendering looks sub-optimal.
> The idea of downloading images at the time of receiving sounds like a
> good solution.

Please keep bulk downloading to a minimum, and remember that most email is spam
these days; I don't want to automatically download anything until I actually
read the message -- if I'm reading the message while the gravatar appears fine,
but once I've closed the message I don't need it.  You could present both the
X-Face and the gravatar as dummy attachments to the file.

--
Tommy Reynolds <Tommy.Reynolds at MegaCoder.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20100110/d2025a2c/attachment.bin