[sylpheed:33238] Re: Bug#551105: sylpheed: Keyboard accelerator in Filter Preferences for "Delete" and "Down" are the same (D)

[Ricardo Mones]

tags 551105 confirmed patch
forwarded 551105 sylpheed at sraoss.jp
thanks

  Hi all,

On Fri, 16 Oct 2009 04:32:31 +1100
ADFH <dbts at bachelorguy.com> wrote:

> Package: sylpheed
> Version: 2.7.1-1
> Severity: minor
> 
> The keyboard accelerators in the "Filter settings" dialog for the "Delete"
> and "Down" buttons are the same, "D".
> 
> This means that pressing Alt+D, instead of triggering a single button,
> instead toggles between two different buttons. One of these should be
> adjusted such that the accelerators are unique.

  Since both are stock buttons is difficult to say which one is "wrong",
  because accelerators are set by GTK+. Also I don't know if the intention
  of the author was to have different accelerators for all buttons, though
  it looks like.

  Anyway, the attached patch seems to fix this on the Delete button to the
  next free accelerator ('l' because 'e' is used by Edit). Of course the
  same can be done on the Down button.

  best regards,

P.S.: To the original reporter: this is being forwarded the upstream mailing
list which is subscription-only, if you're not subscribed please remove it
from the replies to avoid rejections, just keep bug address in Cc.
-- 
 Ricardo Mones
 http://people.debian.org/~mones
 «Among the lucky, you are the chosen one.»
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_551105_duplicate_acels_delete_and_down.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20091024/24ea37c9/attachment.bin