[sylpheed:31297] Re: PGP/MIME-signing breaks sig delimiter

[Godwin Stewart]

On Fri, 11 May 2007 21:07:37 +0200, "Michael Schwendt"
<mschwendt at gmail.com> wrote:

> > In the
> > interim, there's the "brute force" kludge provided by my patch
> > (against sylpheed-2.4.1, incidentally) that restores a correct .sig
> > delimiter in signed messages.
>
> But it doesn't fix the code completely. As long as Sylpheed strips off
> whitespace of other lines, it alters the original message body and
> invalidates other forms of message content. For example, inlined
> unified diffs which contain lines with whitespace at the end.

Well, in that case, you can apply this patch to 2.4.1 instead of the
previous one I sent:

diff -Nurw sylpheed.bak/src/compose.c sylpheed/src/compose.c
--- sylpheed.bak/src/compose.c  2007-04-23 06:33:35.000000000 +0000
+++ sylpheed/src/compose.c      2007-05-12 07:23:20.000000000 +0000
@@ -3076,12 +3076,14 @@

 #if USE_GPGME
        /* chomp all trailing spaces */
+
+       /* NO, DON'T!!! */
        if (rfc2015_is_available() && !is_draft &&
            compose->use_signing && !compose->account->clearsign) {
-               gchar *tmp;
+/*             gchar *tmp;
                tmp = strchomp_all(buf);
                g_free(buf);
-               buf = tmp;
+               buf = tmp;              */
 #if 0
                if (encoding == ENC_7BIT)
                        encoding = ENC_QUOTED_PRINTABLE;

-- 
G. Stewart - gstewart at bonivet.net

"There is no reason for any individual to have a computer in their
home."
                -- Ken Olson, President of DEC, World Future Society
                   Convention, 1977
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20070512/c8915a05/attachment.bin