[pgpool-hackers: 3623] Re: pgPool build error on Fedora 32

[Tatsuo Ishii]

> Hi,
> 
> On Sat, 2020-04-25 at 17:50 +0900, Tatsuo Ishii wrote:
>> Meanwhile I have created a patch to fix the duplicate global
>> data. Can you please try it out?
> 
> Now I'm getting this:
> 
> /usr/bin/ld: streaming_replication/pool_worker_child.o:(.bss+0x0): multiple definition of `remote_ps_data'; protocol/child.o:(.bss+0x460): first defined here
> collect2: error: ld returned 1 exit status
> make[3]: *** [Makefile:768: pgpool] Error 1

Can you please try attached patch? (on top of previous patch)

> Also, I see these warnings:
> 
> gcc -DHAVE_CONFIG_H -DDEFAULT_CONFIGDIR=\"/etc/pgpool-II-12\" -DHEALTHCHECK_OPTS=0 -I. -I../src/include  -D_GNU_SOURCE -I /usr/pgsql-12/include   -g -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-format-truncation -fno-strict-aliasing -c -o rewrite/pool_timestamp.o rewrite/pool_timestamp.c
> In file included from ../src/include/pool.h:28,
>                  from context/pool_session_context.c:25:
> context/pool_session_context.c: In function 'pool_pending_message_query_set':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \

This was stolen from PostgreSQL. So I have no idea why gcc blames it.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pool_worker_child.diff
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200515/5f4933a7/attachment.bin>