[pgpool-hackers: 3622] Re: pgPool build error on Fedora 32

[Devrim Gündüz]

Hi,

On Sat, 2020-04-25 at 17:50 +0900, Tatsuo Ishii wrote:
> Meanwhile I have created a patch to fix the duplicate global
> data. Can you please try it out?

Now I'm getting this:

/usr/bin/ld: streaming_replication/pool_worker_child.o:(.bss+0x0): multiple definition of `remote_ps_data'; protocol/child.o:(.bss+0x460): first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:768: pgpool] Error 1


Also, I see these warnings:

gcc -DHAVE_CONFIG_H -DDEFAULT_CONFIGDIR=\"/etc/pgpool-II-12\" -DHEALTHCHECK_OPTS=0 -I. -I../src/include  -D_GNU_SOURCE -I /usr/pgsql-12/include   -g -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-format-truncation -fno-strict-aliasing -c -o rewrite/pool_timestamp.o rewrite/pool_timestamp.c
In file included from ../src/include/pool.h:28,
                 from context/pool_session_context.c:25:
context/pool_session_context.c: In function 'pool_pending_message_query_set':
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1216:2: note: in expansion of macro 'StrNCpy'
 1216 |  StrNCpy(message->query, query_context->original_query, sizeof(message->query));
      |  ^~~~~~~
context/pool_session_context.c: In function 'pool_pending_message_add':
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1253:5: note: in expansion of macro 'StrNCpy'
 1253 |     StrNCpy(message->portal, message->contents + 1, sizeof(message->portal));
      |     ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1251:5: note: in expansion of macro 'StrNCpy'
 1251 |     StrNCpy(message->statement, message->contents + 1, sizeof(message->statement));
      |     ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1245:4: note: in expansion of macro 'StrNCpy'
 1245 |    StrNCpy(message->portal, message->contents, sizeof(message->portal));
      |    ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1240:4: note: in expansion of macro 'StrNCpy'
 1240 |    StrNCpy(message->portal, message->contents, sizeof(message->portal));
      |    ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1241:4: note: in expansion of macro 'StrNCpy'
 1241 |    StrNCpy(message->statement, message->contents + strlen(message->contents) + 1, sizeof(message->statement));
      |    ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1235:4: note: in expansion of macro 'StrNCpy'
 1235 |    StrNCpy(message->statement, message->contents, sizeof(message->statement));
      |    ^~~~~~~
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1236:4: note: in expansion of macro 'StrNCpy'
 1236 |    StrNCpy(message->query, message->contents + strlen(message->contents) + 1, sizeof(message->query));
      |    ^~~~~~~
context/pool_session_context.c: In function 'pool_temp_tables_add':
../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
  404 |    strncpy(_dst, (src), _len); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
context/pool_session_context.c:1878:3: note: in expansion of macro 'StrNCpy'
 1878 |   StrNCpy(table->tablename, tablename, sizeof(table->tablename));
      |   ^~~~~~~


Regards,
-- 
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200515/515eaf68/attachment.sig>