[pgpool-hackers: 3232] Re: pgbench: Flamegraph

[Tatsuo Ishii]

Hi Jesper,
> 
>> The first question would be: Why is per_node_error_log ->
>> pool_extract_error_message showing up in the profiles when there are
>> no log messages from this; > 6% in each. A quick look shows that
>> pool_extract_error_message shouldn't create strings if they aren't
>> needed. But, that is unlikely the real issue.
>>
>> Use Search (top right corner) and write ^pool_extract_error*
>> Click on the highlighted boxes.
> 
> You are right. If the message kind is not either Error nor Notice,
> there's no need to call pool_extract_error_message at all and this is
> for most cases. Attached patch implements it (against master HEAD).
> 
> Unfortunately I was not able to see any performance enhancement using
> pgbench though.

Forgot to attach the patch.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: per_node_error_log_overhead.diff
Type: text/x-patch
Size: 716 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20190207/5fdbfdd6/attachment.bin>