[pgpool-hackers: 3231] Re: pgbench: Flamegraph

[Tatsuo Ishii]

Hi Hesper,

> The first question would be: Why is per_node_error_log ->
> pool_extract_error_message showing up in the profiles when there are
> no log messages from this; > 6% in each. A quick look shows that
> pool_extract_error_message shouldn't create strings if they aren't
> needed. But, that is unlikely the real issue.
>
> Use Search (top right corner) and write ^pool_extract_error*
> Click on the highlighted boxes.

You are right. If the message kind is not either Error nor Notice,
there's no need to call pool_extract_error_message at all and this is
for most cases. Attached patch implements it (against master HEAD).

Unfortunately I was not able to see any performance enhancement using
pgbench though.

>> Also it would be nice if you kindly show us how to generate flamegraph
>> of Pgpool-II.
>> 
> 
> Sure.

Thanks! This helps me a lot.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp