[pgpool-hackers: 2793] Re: [pgpool-committers: 4697] pgpool: More for SCRAM authentication support, This commit also adds th

[Muhammad Usama]

Hi Ishii-San

On Thu, Apr 26, 2018 at 5:19 AM, Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Usama,
>
> Thanks for the commit.
>
> I guess what you need to do after this are:
>
> 1) Rebase against master branch
>
> 2) Add Regressesion test for the feature
>
> 3) Deal with existing regression tests (With the commit currently they
>    fail like: FATAL: could not load server certificate file "": No
>    such file or directory)
>
> 4) Add README
>
> 5) Provide patch for the code review purpose.  (Please take a look at
>    https://wiki.postgresql.org/wiki/Creating_Clean_Patches to create
>    good quality patches).
>
> Afther this I would love to join the testing work for this.
>

Thanks it would be great.

This is not the final commit. There are still some TODOs left before it is
ready for testing.
I pushed the intermediate patch to dev branch because it was getting bigger
and becoming difficult to manage.
The final commit will take care of all the above points.

Kind Regards
Muhammad Usama

>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
> From: Muhammad Usama <m.usama at gmail.com>
> Subject: [pgpool-committers: 4697] pgpool: More for SCRAM authentication
> support, This commit also adds th
> Date: Wed, 25 Apr 2018 20:26:25 +0000
> Message-ID: <E1fBQzh-00077v-HW at gothos.postgresql.org>
>
> > More for SCRAM authentication support, This commit also adds the support
> for
> > CERT authentication between client and Pgpool-II.
> > The authentication infrastructure of Pgpool-II is also enhanced by this
> commit
> > and now it is possible to use different authentication methods between
> client
> > to Pgpool-II and Pgpool-II to backend.
> >
> > Branch
> > ------
> > SCRAM_AUTH
> >
> > Details
> > -------
> > https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=
> 94d7ac4873aa9e796475cd937def137ce2f91b87
> >
> > Modified Files
> > --------------
> > src/auth/pool_auth.c           | 837 ++++++++++++++++++++++++++++--
> -----------
> > src/auth/pool_hba.c            |  57 ++-
> > src/auth/pool_passwd.c         | 152 ++++++++
> > src/include/auth/pool_hba.h    |   3 +-
> > src/include/auth/pool_passwd.h |  21 +-
> > src/include/pool.h             |  15 +-
> > src/main/main.c                |  22 +-
> > src/main/pgpool_main.c         |   1 -
> > src/protocol/child.c           |   2 +-
> > src/utils/pool_ssl.c           | 364 +++++++++++++++++-
> > 10 files changed, 1187 insertions(+), 287 deletions(-)
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20180426/ad818de9/attachment.html>