<div dir="ltr">Hi Ishii-San<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 26, 2018 at 5:19 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Usama,<br>
<br>
Thanks for the commit.<br>
<br>
I guess what you need to do after this are:<br>
<br>
1) Rebase against master branch<br>
<br>
2) Add Regressesion test for the feature<br>
<br>
3) Deal with existing regression tests (With the commit currently they<br>
fail like: FATAL: could not load server certificate file "": No<br>
such file or directory)<br>
<br>
4) Add README<br>
<br>
5) Provide patch for the code review purpose. (Please take a look at<br>
<a href="https://wiki.postgresql.org/wiki/Creating_Clean_Patches" rel="noreferrer" target="_blank">https://wiki.postgresql.org/<wbr>wiki/Creating_Clean_Patches</a> to create<br>
good quality patches).<br>
<br>
Afther this I would love to join the testing work for this.<br></blockquote><div><br></div><div>Thanks it would be great.</div><div><br></div><div>This is not the final commit. There are still some TODOs left before it is ready for testing.</div><div>I pushed the intermediate patch to dev branch because it was getting bigger and becoming difficult to manage.</div><div>The final commit will take care of all the above points. </div><div><br></div><div>Kind Regards</div><div>Muhammad Usama</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
<br>
From: Muhammad Usama <<a href="mailto:m.usama@gmail.com">m.usama@gmail.com</a>><br>
Subject: [pgpool-committers: 4697] pgpool: More for SCRAM authentication support, This commit also adds th<br>
Date: Wed, 25 Apr 2018 20:26:25 +0000<br>
Message-ID: <<a href="mailto:E1fBQzh-00077v-HW@gothos.postgresql.org">E1fBQzh-00077v-HW@gothos.<wbr>postgresql.org</a>><br>
<div class="HOEnZb"><div class="h5"><br>
> More for SCRAM authentication support, This commit also adds the support for<br>
> CERT authentication between client and Pgpool-II.<br>
> The authentication infrastructure of Pgpool-II is also enhanced by this commit<br>
> and now it is possible to use different authentication methods between client<br>
> to Pgpool-II and Pgpool-II to backend.<br>
> <br>
> Branch<br>
> ------<br>
> SCRAM_AUTH<br>
> <br>
> Details<br>
> -------<br>
> <a href="https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=94d7ac4873aa9e796475cd937def137ce2f91b87" rel="noreferrer" target="_blank">https://git.postgresql.org/<wbr>gitweb?p=pgpool2.git;a=<wbr>commitdiff;h=<wbr>94d7ac4873aa9e796475cd937def13<wbr>7ce2f91b87</a><br>
> <br>
> Modified Files<br>
> --------------<br>
> src/auth/pool_auth.c | 837 ++++++++++++++++++++++++++++--<wbr>-----------<br>
> src/auth/pool_hba.c | 57 ++-<br>
> src/auth/pool_passwd.c | 152 ++++++++<br>
> src/include/auth/pool_hba.h | 3 +-<br>
> src/include/auth/pool_passwd.h | 21 +-<br>
> src/include/pool.h | 15 +-<br>
> src/main/main.c | 22 +-<br>
> src/main/pgpool_main.c | 1 -<br>
> src/protocol/child.c | 2 +-<br>
> src/utils/pool_ssl.c | 364 +++++++++++++++++-<br>
> 10 files changed, 1187 insertions(+), 287 deletions(-)<br>
> <br>
</div></div></blockquote></div><br></div></div>