[pgpool-hackers: 1734] Re: Feature Request with Patch

[Muhammad Usama]

On Thu, Jul 28, 2016 at 4:37 AM, Tatsuo Ishii <ishii at postgresql.org> wrote:

> Usama,
>
> Looks good to me. I think the patch is ready to commit.
>

Thanks I have committed the patch to the master branch.

Best regards
Muhammad Usama


>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
> > Hi
> >
> > I have modified the patch a little and also included the changes for
> "show
> > pool_nodes", "show pool_status" and English documentation.
> >
> > More specifically the changes from the original version are. First, Since
> > this is a new feature that will only go out in next pgpool-II major
> release
> > so instead of adding a command line argument in the pcp_node_info for
> > displaying the human readable status string, I have included it in the
> > standard output of the utility and updated the documentation accordingly.
> > Second, As the pgpool admin extension already shows the human readable
> node
> > status so I don't think we need to touch that.
> >
> > Suggestions and comments.
> >
> > Best regards
> > Muhammad Usama
> >
> >
> >
> > On Tue, May 10, 2016 at 8:26 AM, Tatsuo Ishii <ishii at postgresql.org>
> wrote:
> >
> >> You can either 1) concentrate on working on pcp_node_info and leave
> >> the rest of work (i.e. show pool_nodes) to someone else, or 2) take
> >> care of all the commands including pcp_node_info and show pool_nodes.
> >>
> >> Either is fine for me. The choice is up to you.
> >>
> >> BTW, your coding style is a little bit different from ours. We
> >> strictly follow the PostgreSQL style. For example,
> >>
> >> if (....) {
> >>   ....
> >> } else {
> >>   ....
> >> }
> >>
> >> is not a recommended coding style. We prefer followings:
> >>
> >> if (....)
> >> {
> >>   ....
> >> }
> >> else
> >> {
> >>   ....
> >> }
> >>
> >> Best regards,
> >> --
> >> Tatsuo Ishii
> >> SRA OSS, Inc. Japan
> >> English: http://www.sraoss.co.jp/index_en.php
> >> Japanese:http://www.sraoss.co.jp
> >>
> >> > I can agree that keeping things consistent is a good idea. I'm busy
> this
> >> > week, but I should have time next week to code that up. Any other
> >> > suggestion you want me to get while I"m doing that, because I don't
> >> think I
> >> > have used all the commands. I'll look though the doc's to see what I
> find
> >> > as well, but I wanted to ask in case there is something specific you
> want
> >> > me to do.
> >> >
> >> >
> >> > On May 9, 2016 3:52 AM, "Tatsuo Ishii" <ishii at postgresql.org> wrote:
> >> >
> >> >> > Hey everybody,
> >> >> >   I use pgpool and I noticed that pcp_node_info usually requires
> that
> >> I
> >> >> > have the pgpool docs open in order to interpret the output. As a
> >> result I
> >> >> > would like to propose a '-r --readable' option (-h for
> human-readable
> >> is
> >> >> > taken by host). I posted the small patch needed to do this
> >> >> > http://www.pgpool.net/mantisbt/view.php?id=192 . I am willing to
> do
> >> more
> >> >> > work on this if it is requested. Let me know what the opinion on
> this
> >> is.
> >> >>
> >> >> If we were going to change pcp_node_info, we might want to change
> other
> >> >> places for consistency sake (for example, "show pool_nodes"). What do
> >> >> you think?
> >> >>
> >> >> Best regards,
> >> >> --
> >> >> Tatsuo Ishii
> >> >> SRA OSS, Inc. Japan
> >> >> English: http://www.sraoss.co.jp/index_en.php
> >> >> Japanese:http://www.sraoss.co.jp
> >> >>
> >> _______________________________________________
> >> pgpool-hackers mailing list
> >> pgpool-hackers at pgpool.net
> >> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20160728/2f9fa6ab/attachment.html>