<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 28, 2016 at 4:37 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Usama,<br>
<br>
Looks good to me. I think the patch is ready to commit.<br></blockquote><div><br></div><div>Thanks I have committed the patch to the master branch.</div><div><br></div><div>Best regards</div><div>Muhammad Usama</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div class=""><div class="h5"><br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
> Hi<br>
><br>
> I have modified the patch a little and also included the changes for "show<br>
> pool_nodes", "show pool_status" and English documentation.<br>
><br>
> More specifically the changes from the original version are. First, Since<br>
> this is a new feature that will only go out in next pgpool-II major release<br>
> so instead of adding a command line argument in the pcp_node_info for<br>
> displaying the human readable status string, I have included it in the<br>
> standard output of the utility and updated the documentation accordingly.<br>
> Second, As the pgpool admin extension already shows the human readable node<br>
> status so I don't think we need to touch that.<br>
><br>
> Suggestions and comments.<br>
><br>
> Best regards<br>
> Muhammad Usama<br>
><br>
><br>
><br>
> On Tue, May 10, 2016 at 8:26 AM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
><br>
>> You can either 1) concentrate on working on pcp_node_info and leave<br>
>> the rest of work (i.e. show pool_nodes) to someone else, or 2) take<br>
>> care of all the commands including pcp_node_info and show pool_nodes.<br>
>><br>
>> Either is fine for me. The choice is up to you.<br>
>><br>
>> BTW, your coding style is a little bit different from ours. We<br>
>> strictly follow the PostgreSQL style. For example,<br>
>><br>
>> if (....) {<br>
>> ....<br>
>> } else {<br>
>> ....<br>
>> }<br>
>><br>
>> is not a recommended coding style. We prefer followings:<br>
>><br>
>> if (....)<br>
>> {<br>
>> ....<br>
>> }<br>
>> else<br>
>> {<br>
>> ....<br>
>> }<br>
>><br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> > I can agree that keeping things consistent is a good idea. I'm busy this<br>
>> > week, but I should have time next week to code that up. Any other<br>
>> > suggestion you want me to get while I"m doing that, because I don't<br>
>> think I<br>
>> > have used all the commands. I'll look though the doc's to see what I find<br>
>> > as well, but I wanted to ask in case there is something specific you want<br>
>> > me to do.<br>
>> ><br>
>> ><br>
>> > On May 9, 2016 3:52 AM, "Tatsuo Ishii" <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
>> ><br>
>> >> > Hey everybody,<br>
>> >> > I use pgpool and I noticed that pcp_node_info usually requires that<br>
>> I<br>
>> >> > have the pgpool docs open in order to interpret the output. As a<br>
>> result I<br>
>> >> > would like to propose a '-r --readable' option (-h for human-readable<br>
>> is<br>
>> >> > taken by host). I posted the small patch needed to do this<br>
>> >> > <a href="http://www.pgpool.net/mantisbt/view.php?id=192" rel="noreferrer" target="_blank">http://www.pgpool.net/mantisbt/view.php?id=192</a> . I am willing to do<br>
>> more<br>
>> >> > work on this if it is requested. Let me know what the opinion on this<br>
>> is.<br>
>> >><br>
>> >> If we were going to change pcp_node_info, we might want to change other<br>
>> >> places for consistency sake (for example, "show pool_nodes"). What do<br>
>> >> you think?<br>
>> >><br>
>> >> Best regards,<br>
>> >> --<br>
>> >> Tatsuo Ishii<br>
>> >> SRA OSS, Inc. Japan<br>
>> >> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> >> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>> >><br>
>> _______________________________________________<br>
>> pgpool-hackers mailing list<br>
>> <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
>> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
>><br>
</div></div></blockquote></div><br></div></div>