[pgpool-hackers: 325] Re: patch for pgpool-II regression framework

Muhammad Usama m.usama at gmail.com
Thu Jul 25 18:47:39 JST 2013


Hi

I overlooked the newly added watchdog test. Please find the updated
attached patch

Thanks
Muhammad Usama


On Wed, Jul 24, 2013 at 7:18 PM, Tatsuo Ishii <ishii at postgresql.org> wrote:

> The patch does not include changes for
> test/regression/tests/004.watchdog/test.sh.
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese: http://www.sraoss.co.jp
>
> > Thanks Tatsuo
> >
> > Are you getting hunk failed with the patch?  Patch is applying cleanly on
> > the latest code base at my end.
> >
> > Thanks
> > Muhammad Usama
> >
> >
> > On Tue, Jul 23, 2013 at 7:00 PM, Tatsuo Ishii <ishii at postgresql.org>
> wrote:
> >
> >> Thanks! However your patch looks a little bit outdated. Can you please
> >> post rebased version?
> >> --
> >> Tatsuo Ishii
> >> SRA OSS, Inc. Japan
> >> English: http://www.sraoss.co.jp/index_en.php
> >> Japanese: http://www.sraoss.co.jp
> >>
> >> > Hi
> >> >
> >> > I tried to make some changes in the regression script, mainly because
> the
> >> > script uses lot of hard coded paths and regression starts reporting
> >> > failures if the pgpool-II or PostgreSQL are not found at the default
> >> path.
> >> >
> >> > Please find the attached patch which enables the regress.sh script to
> >> > install the pgpool on fly in temp directory to run the tests on it
> >> > (optional), and now the regress script takes some additional
> arguments to
> >> > specify the paths of required components.
> >> >
> >> > The list of all arguments accepted by regress.sh script as
> implemented by
> >> > the attached patch are
> >> > pgpool2/test/regression$ sh regress.sh -?
> >> > Usage:
> >> >   regress.sh: [Options]... [test_name]
> >> >
> >> > Options:
> >> >   -p   DIRECTORY           Postgres installed directory
> >> >   -b   DIRECTORY           pgbench installed directory, if different
> from
> >> > Postgres installed directory
> >> >   -i   DIRECTORY           pgpool installed directory, if already
> >> installed
> >> > pgpool is to be used for tests
> >> >   -m   install/noinstall   make install pgpool to temp directory for
> >> > executing regression tests [Default: install]
> >> >   -j    FILE               Postgres jdbc jar file path
> >> >   -?                       print this help and then exit
> >> >
> >> > Thanks
> >> > Regards
> >> >
> >> > Muhammad Usama
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20130725/34d462bc/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: regression2.patch
Type: application/octet-stream
Size: 17947 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20130725/34d462bc/attachment-0001.obj>


More information about the pgpool-hackers mailing list