<div dir="ltr">Hi<div><br></div><div style>I overlooked the newly added watchdog test. Please find the updated attached patch</div><div style><br></div><div style>Thanks</div><div style>Muhammad <span class="" style>Usama</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 24, 2013 at 7:18 PM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The patch does not include changes for test/regression/tests/004.watchdog/test.sh.<br>
<div class="HOEnZb"><div class="h5">--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
> Thanks Tatsuo<br>
><br>
> Are you getting hunk failed with the patch? Patch is applying cleanly on<br>
> the latest code base at my end.<br>
><br>
> Thanks<br>
> Muhammad Usama<br>
><br>
><br>
> On Tue, Jul 23, 2013 at 7:00 PM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
><br>
>> Thanks! However your patch looks a little bit outdated. Can you please<br>
>> post rebased version?<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> > Hi<br>
>> ><br>
>> > I tried to make some changes in the regression script, mainly because the<br>
>> > script uses lot of hard coded paths and regression starts reporting<br>
>> > failures if the pgpool-II or PostgreSQL are not found at the default<br>
>> path.<br>
>> ><br>
>> > Please find the attached patch which enables the regress.sh script to<br>
>> > install the pgpool on fly in temp directory to run the tests on it<br>
>> > (optional), and now the regress script takes some additional arguments to<br>
>> > specify the paths of required components.<br>
>> ><br>
>> > The list of all arguments accepted by regress.sh script as implemented by<br>
>> > the attached patch are<br>
>> > pgpool2/test/regression$ sh regress.sh -?<br>
>> > Usage:<br>
>> > regress.sh: [Options]... [test_name]<br>
>> ><br>
>> > Options:<br>
>> > -p DIRECTORY Postgres installed directory<br>
>> > -b DIRECTORY pgbench installed directory, if different from<br>
>> > Postgres installed directory<br>
>> > -i DIRECTORY pgpool installed directory, if already<br>
>> installed<br>
>> > pgpool is to be used for tests<br>
>> > -m install/noinstall make install pgpool to temp directory for<br>
>> > executing regression tests [Default: install]<br>
>> > -j FILE Postgres jdbc jar file path<br>
>> > -? print this help and then exit<br>
>> ><br>
>> > Thanks<br>
>> > Regards<br>
>> ><br>
>> > Muhammad Usama<br>
>><br>
</div></div></blockquote></div><br></div>