[pgpool-hackers: 343] Re: reorganisation of pgpool-II source tree

[Tatsuo Ishii]

I checked the patch and noticed some issues:

1) missing patch for test/regression/tests/058.bug68

2) missing x permission for src/test/regression/tests/*/test.sh

Can you please revise the patch?

In addition to them, after git commit and git clean -dfx still leaves
test/pdo-test and test/regression.  I'm not sure but I suspect this is
caused by a bug of git.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

> Oops. I seemed to forgot that now most of codes under src
> directory. Sorry for noise.
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese: http://www.sraoss.co.jp
> 
>> The patch does add all the files, But the files needed to be added back to
>> git repository.
>> You can issue "git add -A" command after applying the patch.
>> 
>> usama at ubuntu:~/EDB/test/pgpool2$ patch -p1 -b <
>> /mnt/hgfs/usama/EDB/pgpool/NewTree/test/code_rearrange.patch
>> patching file INSTALL
>> patching file Makefile.am
>> patching file Makefile.in
>> patching file aclocal.m4
>> patching file child.c
>> patching file compile
>> patching file config.guess
>> patching file config.h.in
>> patching file config.sub
>> ...
>> usama at ubuntu:~/EDB/test/pgpool2$ git status
>> # On branch master
>> # Changes not staged for commit:
>> #   (use "git add/rm <file>..." to update what will be committed)
>> #   (use "git checkout -- <file>..." to discard changes in working
>> directory)
>> #
>> # modified:   INSTALL
>> # modified:   Makefile.am
>> # modified:   Makefile.in
>> # deleted:    parser/Makefile.in
>> # deleted:    parser/copyfuncs.c
>> # deleted:    parser/gram.c
>> # deleted:    parser/gram.h
>> # deleted:    parser/gram.y
>> ...
>> usama at ubuntu:~/EDB/test/pgpool2$ git add -A
>> usama at ubuntu:~/EDB/test/pgpool2$ git status
>> # On branch master
>> # Changes to be committed:
>> #   (use "git reset HEAD <file>..." to unstage)
>> #
>> # modified:   INSTALL
>> # modified:   Makefile.am
>> # modified:   Makefile.in
>> # renamed:    pool_auth.c -> src/auth/pool_auth.c
>> # renamed:    pool_hba.c -> src/auth/pool_hba.c
>> # renamed:    pool_passwd.c -> src/auth/pool_passwd.c
>> # renamed:    pool_config.c -> src/config/pool_config.c
>> # renamed:    pool_config.l -> src/config/pool_config.l
>> ...
>> 
>> Thanks
>> Muhammad Usama
>> 
>> 
>> 
>> On Thu, Aug 8, 2013 at 6:27 PM, Tatsuo Ishii <ishii at postgresql.org> wrote:
>> 
>>> Thanks but that seems to just remove most of files but never create
>>> new directories or reorganized source codes.
>>>
>>> I did:
>>> patch -b -p1 < code_rearrange.patch
>>> --
>>> Tatsuo Ishii
>>> SRA OSS, Inc. Japan
>>> English: http://www.sraoss.co.jp/index_en.php
>>> Japanese: http://www.sraoss.co.jp
>>>
>>> > Hi Tatsuo.
>>> >
>>> > Please find the attached code reorganisation patch.
>>> >
>>> > Thanks
>>> > Muammad Usama
>>> >
>>> >
>>> >
>>> > On Wed, Aug 7, 2013 at 7:48 AM, Tatsuo Ishii <ishii at postgresql.org>
>>> wrote:
>>> >
>>> >> Usama,
>>> >>
>>> >> Can you please provide me the patch against git master at this moment?
>>> >> I'm going to start to applying code reorganization patch.
>>> >> --
>>> >> Tatsuo Ishii
>>> >> SRA OSS, Inc. Japan
>>> >> English: http://www.sraoss.co.jp/index_en.php
>>> >> Japanese: http://www.sraoss.co.jp
>>> >>
>>> >> > Hi
>>> >> >
>>> >> > I have re-based the code reorganised pgpool2 repository (
>>> >> > https://github.com/codeforall/pgpool2) with the current master.
>>> >> >
>>> >> > Thanks
>>> >> >
>>> >> > On Mon, Jul 22, 2013 at 12:00 PM, Tatsuo Ishii <ishii at postgresql.org>
>>> >> wrote:
>>> >> >
>>> >> >> > Thanks Tatsuo. When will you begin committing changes for 3.4?
>>> >> >>
>>> >> >> 3.2 is supposed to be released by the end of July. So the commit
>>> >> >> surely happens after that. Also I need to be very careful about
>>> >> >> incorporating such a big change into the repository. Probably I will
>>> >> >> create a test repository then try to apply patches from Usama (Usama
>>> >> >> needs to create rebased patch for this. Current changes in his
>>> >> >> repository are already outdated). That says, committing the patch
>>> will
>>> >> >> be by the end of August, I guess.
>>> >> >> --
>>> >> >> Tatsuo Ishii
>>> >> >> SRA OSS, Inc. Japan
>>> >> >> English: http://www.sraoss.co.jp/index_en.php
>>> >> >> Japanese: http://www.sraoss.co.jp
>>> >> >>
>>> >>
>>>