[sylpheed:36382] Re: [ANNOUNCE] Sylpheed 3.5rc released

[Hiroyuki Yamamoto]

Hello,

On Sun, 29 Nov 2015 06:14:38 +0100
Gisle Vanem <gvanem at yahoo.no> wrote:

> But there are more problems with the new code. The update-check
> at startup. Essentially:
>   curl --silent --max-time 10 http://sylpheed.sraoss.jp/version.txt?ver=3.5.0.&os=win
> 
> never finishes because of missing escapes of the "&". A simple patch
> that works here:

The original code works here. Maybe there are some differences between
MinGW and MSVC?

> --- a/update_check.c 2015-11-27 11:57:27
> +++ b/update_check.c                   2015-11-29 06:06:38
> @@ -720,7 +720,7 @@
> 
>         if (!check_plugin_url) {
>  #ifdef G_OS_WIN32
> -               g_snprintf(buf, sizeof(buf), "%s?ver=%s&os=win", PLUGIN_VERSION_URI, VERSION);
> +               g_snprintf(buf, sizeof(buf), "\"%s?ver=%s&os=win\"", PLUGIN_VERSION_URI, VERSION);
>  #else
>                 if (strstr(TARGET_ALIAS, "linux"))
>                         g_snprintf(buf, sizeof(buf), "%s?ver=%s&os=linux", PLUGIN_VERSION_URI, VERSION);
> 
> 
> (the "&" is a command separator on Windows).
> But there are more strange stuff in update_check.c...


-- 
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp>