[sylpheed:35202] Re: [ANNOUNCE] Sylpheed 3.2beta5 released

[Ricardo Mones]

  Hi Hiroyuki,

On Wed, 28 Mar 2012 17:36:02 +0900
Hiroyuki Yamamoto <hiro-y at kcn.ne.jp> wrote:

> Sorry for the very late reply,

  No problem, no hurry :)
 
> On Thu, 29 Dec 2011 00:59:55 +0100
> Ricardo Mones <mones at debian.org> wrote:
> 
> > On Wed, 28 Dec 2011 13:30:43 +0900
> > Hiroyuki Yamamoto <hiro-y at kcn.ne.jp> wrote:
> > 
> > > Sylpheed 3.2beta5 has been released.
> > 
> >   Congrats! The Debian packages are uploaded including a fix to
> > remove a couple of warnings. You can found it here:
> >   http://anonscm.debian.org/gitweb/?p=users/mones/sylpheed.git;a=blob_plain;f=patches/09fix_pointer_cast_size_mismatch.diff;hb=9e5d71c525f7674ee43c8b7281ad3eb254b44403
> 
> This patch might cause a problem, because it passes the pointer to
> show_dialog_always, which will be immediately become invalid after
> calling spawn_curl() in update_check().
> 
> The invalid pointer is then referred in update_check_cb() after
> Sylpheed entering event loop.

  Good catch, I didn't notice that.
 
> Maybe GINT_TO_POINTER()/GPOINTER_TO_INT() macros should be used.

  I've updated the patch following your suggestion for the beta7
packaging:
http://anonscm.debian.org/gitweb/?p=users/mones/sylpheed.git;a=blob;f=patches/09fix_pointer_cast_size_mismatch.diff;h=ba688350d66f736a89ea9addba4978054b0e6123;hb=61ae1db6517af345d779d8f7e8f20ba174bf5b4d

  regards,
-- 
 Ricardo Mones
 http://people.debian.org/~mones
 «Nothing so needs reforming as other people's habits. -- Mark Twain, 
 "Pudd'nhead Wilson's Calendar"»
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/sylpheed/attachments/20120415/11baa08e/attachment.sig>