[sylpheed:34667] Re: Short tags in displaying xhtml-only mails

Ervin Peters ervin.peters at ervnet.de
Wed Jul 20 17:25:00 JST 2011


Just an additional hint:

<br />, with a space before />, is, AFAIK, a valid short tag, too, and
it is widely used.

Thanks,

ervin

Am Wed, 20 Jul 2011 17:11:09 +0900 schrieb Hiroyuki Yamamoto
<hiro-y at kcn.ne.jp>:

> Hello,
> 
> On Tue, 19 Jul 2011 21:42:38 +0200
> Ervin Peters <ervin.peters at ervnet.de> wrote:
> 
> > There is something in html.c line 470 which looks like
> > 
> > 	if (!strcmp(tag->name, "br")) {
> > 		parser->space = FALSE;
> > 		html_append_char(parser, '\n');
> > 		parser->state = HTML_BR;
> > 
> > and mayby could be changed to
> > 
> > 	if (strcasecmp(tag->name, "br", 2 ) <= 0) {
> > 		parser->space = FALSE;
> > 		html_append_char(parser, '\n');
> > 		parser->state = HTML_BR;
> > 
> > similar with the hr tag on line 505.
> > 
> > line numbers from sylpheed-3.2.0beta1, currently downloaded
> 
> I have fixed the html parser at svn r2927. Thanks for pointing it out.
> 
> I modified html_get_tag() instead to handle the following case
> correctly:
> 
>  <br/>
>  <name value="foo" />
> 


-- 
Ervin Peters
Paul-Klee-Str.10
D-99425 Weimar

+49 172 2043926
+49 3643 805745
skype: ervin.peters


More information about the Sylpheed mailing list