[sylpheed:31307] Re: PGP/MIME-signing breaks sig delimiter

[Godwin Stewart]

On Mon, 14 May 2007 12:48:43 +0200, "Michael Schwendt"
<mschwendt at gmail.com> wrote:

> You can only preserve it with QP encoding, anyway, and that is in
> compliance with the RFC.

Or base64 - but obviously with the 33% increase in data volume.

As for the comment that some MUAs have difficulty with
quoted-printable, I really don't think that's sylpheed's problem.
As ひろゆきさん already pointed out, Outlook Express is broken anyway
and is totally incapable of handling PGP/MIME. I wouldn't lose any
sleep over that.

Eudora? How many people use that nowadays? And isn't it breaking the
principle of being liberal in what it receives and strict in what it
sends if it doesn't even cope correctly with standards-compliant
messages? If *any* MUA makes material changes to the message body
before verifying a signature then its logic is flawed right from the
outset.

This patch against 2.4.1 should revert to the previous behaviour but
with the exception outlined by ひろゆきさん in message #31301:

diff -Nurw sylpheed.bak/src/compose.c sylpheed/src/compose.c
--- sylpheed.bak/src/compose.c  2007-04-23 06:33:35.000000000 +0000
+++ sylpheed/src/compose.c      2007-05-14 11:04:10.000000000 +0000
@@ -3075,19 +3075,26 @@
        buf = canon_buf;

 #if USE_GPGME
-       /* chomp all trailing spaces */
        if (rfc2015_is_available() && !is_draft &&
            compose->use_signing && !compose->account->clearsign) {
+#if 0
+               /* chomp all trailing spaces */
                gchar *tmp;
                tmp = strchomp_all(buf);
                g_free(buf);
                buf = tmp;
-#if 0
-               if (encoding == ENC_7BIT)
+#endif
+               if ( out_charset == CS_ISO_2022_JP ) {
+                       encoding = ENC_7BIT;
+                       gchar *tmp;
+                       tmp = strchomp_all(buf);
+                       g_free(buf);
+                       buf = tmp;
+               }
+               else if (encoding == ENC_7BIT)
                        encoding = ENC_QUOTED_PRINTABLE;
                else if (encoding == ENC_8BIT)
                        encoding = ENC_BASE64;
-#endif
        }

        if (rfc2015_is_available() && !is_draft &&

-- 
G. Stewart - gstewart at bonivet.net

Maintainer's Motto:
        If we can't fix it, it ain't broke.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20070514/c3a44929/attachment.bin