[sylpheed:31973] Re: [PATCH] Sylpheed 2.4.7 memory leak in LDAP

[Michael Schwendt]

On 17/12/2007, Hiroyuki Yamamoto wrote:
>
> > In syldap.c, function syldap_search(), in the  "/* Process all
> > attributes */" loop, why is only the last "attribute" pointer freed
> > with ldap_memfree() after the loop is done? As I understand it, both
> > ldap_first_attribute() and ldap_next_attribute() return a dynamically
> > allocated array of char every time (or NULL), which ought to be freed
> > after each iteration of the loop. IMO:
>
> You are correct, and there were four more leaks in syldap.c :)
> Fixed in svn trunk.

Good!

The following warning remains, though, as the second patch was not
applied completely:

 (sylpheed:19612): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed

But perhaps it only happens here.
$ rpm -q gtk2
gtk2-2.12.1-5.fc8