[sylpheed:31963] [PATCH] Sylpheed 2.4.7 critical glib warning

[Michael Schwendt]

---------- Forwarded message ----------
From: Michael Schwendt
Date: 1 Nov 2007 23:55
Subject: Re: Sylpheed 2.4.7 segfault in LDAP search
To: Hiroyuki Yamamoto


(sylpheed:27498): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed

Here's one fix to get rid of the warning. Btw, the gtk_idle* functions
are deprecated.

--- syldap.c.orig       2006-08-31 10:21:21.000000000 +0200
+++ syldap.c    2007-11-01 23:50:30.000000000 +0100
@@ -637,16 +636,15 @@

 /* syldap_display_search_results() - updates the ui. this function is
called from the
  * main thread (the thread running the GTK event loop). */
-static gint syldap_display_search_results(SyldapServer *ldapServer)
+static gboolean syldap_display_search_results(SyldapServer *ldapServer)
 {
        /* NOTE: when this function is called the accompanying thread should
         * already be terminated. */
-       gtk_idle_remove(ldapServer->idleId);
        ldapServer->callBack(ldapServer);
        /* FIXME:  match should know whether to free this SyldapServer stuff. */
        g_free(ldapServer->thread);
        ldapServer->thread = NULL;
-       return TRUE;
+       return FALSE;
 }

 /* ============================================================================================
*/