[sylpheed:30418] [PATCH] Gtk-CRITICAL **: gtk_progress_set_percentage

[Sebastian Kärgel]

On Thu, 16 Nov 2006 21:15:58 +0100
Frank Lanitz <linux at partysoke.de> wrote:

> Yes, I'm using IMAP. But I'm not sure if it is realy IMAP, because
> always when I saw this message, I was browsing inside a lokal mailbox,
> filled by POP, before. But I realy don't have any idea.

After some testing and debugging I found the following:

libsylph/imap.c:imap_get_uncached_messages:

While the for-loop is running, count and exist get the following values:

enter for-loop in imap_get_uncached_messages: count:1 exists:3
enter for-loop in imap_get_uncached_messages: count:2 exists:3
enter for-loop in imap_get_uncached_messages: count:3 exists:3
enter for-loop in imap_get_uncached_messages: count:4 exists:3

If ui_update() is called at the point where count > exists the
Gtk-CRITICAL warning is displayed, because it cannot display more than
100%.

I just fixed it with the attached patch. Don't know if it's 100%
correct, but it seems to do the trick.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sylpheed-2.2.10-gtk-progress-set-percentage-fix.patch
Type: text/x-patch
Size: 493 bytes
Desc: not available
Url : http://www.sraoss.jp/pipermail/sylpheed/attachments/20061116/e51642fa/attachment.bin