[pgpool-hackers: 2808] Re: [pgpool-committers: 4727] pgpool: Do not set writing tx flag with SET TRANSACTION READ ONLY.

Tatsuo Ishii ishii at sraoss.co.jp
Thu May 24 11:22:42 JST 2018

I have fixed following bug for master to 3.5 stable. From 3.5, writing
transaction flag need to be set in execute() since subsequent commands
need to care about the flag. Doing this in CommandComplete is too late
because users can send multiple commands before sync message in 3.5 or
later. So the fix has been applied to master to 3.5
only. CommandComplete already takes care "SET TRANSACTION READ ONLY"
properly. Just execute() forgot about the command.

Best regards,
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php

> Do not set writing tx flag with SET TRANSACTION READ ONLY.
> In extended query mode, execute() sets the flag upon completion of
> writing queries.  However the flag was set even when SET TRANSACTION
> READ ONLY is issued.  Fix this by using
> pool_is_transaction_read_only(). This has been already done in simple
> query case.
> Branch
> ------
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=c88c336e77502f8b2a026914e918201b5becb544
> Modified Files
> --------------
> src/protocol/pool_proto_modules.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)

More information about the pgpool-hackers mailing list