[pgpool-committers: 6280] pgpool: Fix assorted ancient v2 protocol bugs.

[Tatsuo Ishii]

Fix assorted ancient v2 protocol bugs.

- In v2 code path, extract_message() pfrees memory which was returned
  from pool_read_string(). This is plain wrong and could cause sefault
  since the memory returned by it is being managed by pool_stream
  modules.

- In v2 code path pool_process_notice_message_from_one_backend() added
  "NOTICE:" to the log message. This is not necessary as the part is
  already included in the message.

- In v2 code path pool_extract_error_message() did not prepare unread
  data correctly. This caused subsequent
  pool_process_notice_message_from_one_backend() produces empty
  message, read_kind_from_backend() failure.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3f0c3228dd510472a9aa12f8be3652ff76a42b23

Modified Files
--------------
src/protocol/pool_process_query.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)