[sylpheed:36380] Re: [ANNOUNCE] Sylpheed 3.5rc released

[Gisle Vanem]

Gene Goldenfeld wrote:

> Patched Win32 version won't start after extracting and copying in the
> files. It throws up an "Entry Point Not Found" error message.
> Screenshot: http://tinypic.com/m/j5cv1h/1. Win 8.1

That message from Win 8.1 seems highly misleading; 'g_once_init_enter()'
is supposed to be exported from your Glib. Here it is in libglib-2.0-0.dll.

But there are more problems with the new code. The update-check
at startup. Essentially:
  curl --silent --max-time 10 http://sylpheed.sraoss.jp/version.txt?ver=3.5.0.&os=win

never finishes because of missing escapes of the "&". A simple patch
that works here:

--- a/update_check.c 2015-11-27 11:57:27
+++ b/update_check.c                   2015-11-29 06:06:38
@@ -720,7 +720,7 @@

        if (!check_plugin_url) {
 #ifdef G_OS_WIN32
-               g_snprintf(buf, sizeof(buf), "%s?ver=%s&os=win", PLUGIN_VERSION_URI, VERSION);
+               g_snprintf(buf, sizeof(buf), "\"%s?ver=%s&os=win\"", PLUGIN_VERSION_URI, VERSION);
 #else
                if (strstr(TARGET_ALIAS, "linux"))
                        g_snprintf(buf, sizeof(buf), "%s?ver=%s&os=linux", PLUGIN_VERSION_URI, VERSION);


(the "&" is a command separator on Windows).
But there are more strange stuff in update_check.c...

-- 
--gv