<div dir="ltr"><div dir="ltr">Hi Tatsuo Ishii, <div>Thanks for review. Please see comments inline:</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 16, 2020 at 3:33 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Umar,<br>
<br>
Thank you for the patch! That must be a hard work.<br>
<br>
Here are some comments:<br>
<br>
(1) I got some whitespace errors while applying patches.<br>
<br>
../language_fixes/v1-001-blackwhite-to-redgreen.diff:978: trailing whitespace.<br>
Add new parameter <xref linkend="guc-red-query-pattern-list"> to enable <br>
../language_fixes/v1-002-Watchdog-master-leader.diff:4417: trailing whitespace.<br>
# test if leader and backend goes down at same time Pgpool-II behaves as expected <br>
../language_fixes/v1-007-follow_master-and-recovery-and-misc.diff:13476: trailing whitespace.<br>
<br>
../language_fixes/v1-007-follow_master-and-recovery-and-misc.diff:13488: trailing whitespace.<br>
<br>
warning: 4 lines add whitespace errors.<br>
<br></blockquote><div>I will fix them in next patch. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Hi Team,<br>
> Attached patches for inclusive language for pgpool. please find few details<br>
> about each patch bellow:<br>
> v1-001-blackwhite-to-redgreen<br>
> Replace black with red and white with green for white_function_list,<br>
> black_function_list, black_query_pattern, white_memqcache_table_list,<br>
> black_memqcache_table_list<br>
<br>
Replacing to red and green is a little bit confusing to me. What<br>
about denylist/allowlist? It's suggested by Linux.<br>
<br></blockquote><div>Yes, I read few Linux related articles and few other sources too. denylist/allowlist is used for decision where we either allow or deny. In our case, based on mutability factor we decide whether we should send query to primary or standby. So in-fact we are not blocking queries. </div><div>IMO we can use </div><div>1. deny/allow ( e.g allow_function_list, deny_function_list, allow_query_pattern, allow_memqcache_table_list, deny_memqcache_table_list) ?</div><div>2. or descriptive term like mutable/immutable & safe/unsafe based on pgpool usage ( e.g. mutable_function_list, immutable_function_list, safe_query_pattern, safe_memqcache_table_list, unsafe_memqcache_table_list ) ?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> v1-002-Watchdog-master-leader<br>
> Replace master to 'leader' for 'master' watchdog nodes<br>
<br>
Sounds reasonable choice to me.<br>
<br>
> v1-003-ALWAYS_MASTER-to-ALWAYS_PRIMARY<br>
> Replace backend_flagx option 'ALWAYS_MASTER' with 'ALWAYS_PRIMARY'<br>
<br>
Sounds good to me.<br>
<br>
> v1-004-relcache_query_target--master-to-primary<br>
> Replace relcache_query_target option 'master' to 'primary'<br>
<br>
Sounds good to me.<br>
<br>
> v1-005-master-slave-to-primarystandby<br>
> Replace Master/Slave with Primary/Secondary<br>
<br>
I think we could replace "Master/Slave mode" to "Native replication<br>
mode".<br>
<br>
Using "Primary" as the replacemnet for "Master" sounds is confusing as<br>
there's "Primary" in the streaming replication mode.<br>
<br></blockquote><div>I will use Native Replication mode in next patch. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> v1-006-masterslave-to-mainreplica<br>
> Replace Master Node with Main node ( node id with 0 or youngest live )<br>
> Couldn't translate with primary/leader as they were already used in<br>
> different context<br>
<br>
Sounds good to me.<br>
<br>
> v1-007-follow_master-and-recovery-and-misc<br>
> Replace follow_master with follow_primary with parameters replaced with<br>
> new/old master with new/old main.<br>
> Replace some remaining occurrences of master with primary/main/leader<br>
<br>
Sounds good to me.<br>
<br>
> In the above patches I didn't change older releases notes ( except for some<br>
> links so they don't break and point to new terminology), history, TODO and<br>
> Japanese Doc string.<br>
<br>
Sounds good to me. (I will take care of Japanese Doc string).<br>
<br>
> Postmaster ( It's used around 150 times ) and very few other occurrences of<br>
> 'master' are still present.<br>
<br>
No objection from me.<br>
<br>
> There are alot of inter-dependent terminologies and so I might have missed<br>
> something. Looking at them as a whole makes some sense, changing one term<br>
> might lead to inconsistency in some other areas.<br>
> I tried to come up with the above terminologies, just to start<br>
> conversation. Feel free to share feedback and comments.<br>
<br>
Thanks.<br>
<br>
> Regards<br>
> Umar Hayat<br>
> <br>
> <br>
> On Fri, Sep 4, 2020 at 8:03 AM Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
> <br>
>> Hi Tatsuou Ishii,<br>
>> Yes I'm planning for 4.2 and work is in progress, I will send patches in<br>
>> the upcoming week.<br>
>><br>
>> Regards<br>
>> Umar Hayat<br>
>><br>
>> On Thu, Sep 3, 2020 at 5:59 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
>><br>
>>> Hi Umar,<br>
>>><br>
>>> Now that we are getting closer to release Pgpool-II 4.2, I would like<br>
>>> to know if you wish to bring your work into 4.2 or not. If you wish,<br>
>>> can you please tell us the time line for the patch?<br>
>>><br>
>>> > On Fri, Jul 24, 2020 at 4:33 PM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>><br>
>>> wrote:<br>
>>> ><br>
>>> >> > Hi Hackers,<br>
>>> >> > Recently PG community did a language clean up ( to make it more<br>
>>> >> inclusive )<br>
>>> >> > for Server, including docs and code (see here<br>
>>> >> > <<br>
>>> >><br>
>>> <a href="https://www.postgresql.org/message-id/20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de" rel="noreferrer" target="_blank">https://www.postgresql.org/message-id/20200615182235.x7lch5n6kcjq4aue@alap3.anarazel.de</a><br>
>>> >> >).<br>
>>> >> > Most changes were related to renaming "slave" and "master"<br>
>>> terminologies.<br>
>>> >> > Do we have any plans to make such changes to make pgpool consistent<br>
>>> with<br>
>>> >> > Server as well as in general Pgpool specific things ?<br>
>>> >> > If we do have a plan, it would need multiple patches as it would<br>
>>> affect<br>
>>> >> > docs, code and configuration and samples.<br>
>>> >> > Let me know suggestions and thoughts and I can work on this.<br>
>>> >><br>
>>> >> It seems the discussion is still on going? I mean it has not been<br>
>>> >> committed yet?<br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> <a href="https://www.postgresql.org/message-id/flat/20200615182235.x7lch5n6kcjq4aue%40alap3.anarazel.de" rel="noreferrer" target="_blank">https://www.postgresql.org/message-id/flat/20200615182235.x7lch5n6kcjq4aue%40alap3.anarazel.de</a><br>
>>> >><br>
>>> >> Discussion is going on for two pending point which are not part of<br>
>>> patches<br>
>>> > ( postmaster & master branch) and one WIP patch(multi-master), rest of<br>
>>> the<br>
>>> > 7 patches for that thread are committed.<br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=229f8c219f8fffacc253eca6023eab10a16eb009" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=229f8c219f8fffacc253eca6023eab10a16eb009</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5e7bbb528638c0f6d585bab107ec7a19e3a39deb" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5e7bbb528638c0f6d585bab107ec7a19e3a39deb</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=e07633646a22734e85d7fc58a66855f747128e6b" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=e07633646a22734e85d7fc58a66855f747128e6b</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e101cf60612f4be4f855d7393531900c2986a55" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e101cf60612f4be4f855d7393531900c2986a55</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=09dfd430118f1fadf52a782db5ee161b1eb16337" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=09dfd430118f1fadf52a782db5ee161b1eb16337</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=7c89f8a5b810d10dae300ec58ea7d70024e9123e" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=7c89f8a5b810d10dae300ec58ea7d70024e9123e</a><br>
>>> ><br>
>>> <a href="https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a9a4a7ad565b136cbee735d4bb505d98d06da522" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a9a4a7ad565b136cbee735d4bb505d98d06da522</a><br>
>>> ><br>
>>> ><br>
>>> >> The topic has not been discussed yet in pgpool-hackers, but I<br>
>>> >> personally think we need to do something soon or later anyway. My<br>
>>> >> concern is that that might require user-visible changes like:<br>
>>> >><br>
>>> >> master<br>
>>> >> slave<br>
>>> >> white_function_list<br>
>>> >> black_function_list<br>
>>> >> black_query_pattern_list<br>
>>> >> white_memqcache_table_list<br>
>>> >> black_memqcache_table_list<br>
>>> >> follow_master_command<br>
>>> >> relcache_query_target = master<br>
>>> >> [maybe more...]<br>
>>> >><br>
>>> >> Is it possible for you to come with a proposal for this so that pgpool<br>
>>> >> hackers could start discussion?<br>
>>> >><br>
>>> >> Best regards,<br>
>>> >> --<br>
>>> >> Tatsuo Ishii<br>
>>> >> SRA OSS, Inc. Japan<br>
>>> >> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>>> >> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>>> ><br>
>>> ><br>
>>> > Sure, I will create proposal for different sections and patches to<br>
>>> discuss<br>
>>> > it further.<br>
>>> ><br>
>>> > Thanks<br>
>>> > Umar Hayat<br>
>>><br>
>><br>
</blockquote></div></div>