<div dir="ltr"><div dir="ltr">Hi Peng,<div>Any feedback ?</div><div><br></div><div>Regards</div><div>Umar Hayat</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 7, 2020 at 1:51 PM Umar Hayat <<a href="mailto:m.umarkiani@gmail.com">m.umarkiani@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Peng, <div>Please find attached updated patch with absolute path support, regression test 029 covers absolute path support.</div><div><br></div><div>Regards</div><div>Umar Hayat</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 1, 2020 at 9:39 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
On Mon, 27 Apr 2020 18:22:56 +0500<br>
Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
<br>
> Hi Hackers,<br>
> Please find attached patch for following TODO item<br>
> <a href="https://pgpool.net/mediawiki/index.php/TODO#Change_relative_path_of_ssl_key_and_ssl_cert_to_DEFAULT_CONFIGDIR" rel="noreferrer" target="_blank">https://pgpool.net/mediawiki/index.php/TODO#Change_relative_path_of_ssl_key_and_ssl_cert_to_DEFAULT_CONFIGDIR</a><br>
<br>
Thank you for your patch.<br>
<br>
I reviewed and testet your patch.<br>
It seems absolute path can't be used in these parameters.<br>
<br>
Could you add the support for absolute path?<br>
<br>
> All SSL artefact files (key, cert, ca_cert, crl) paths will be relative to<br>
> configuration directory (pgpool.conf path). DEFAULT_CONFIGDIR<br>
> configuration always point to location what we specify at build time. This<br>
> patch use the path of pgpool.conf directory path instead<br>
> of DEFAULT_CONFIGDIR, so that custom path of configuration can be used. (<br>
> like we do in regression)<br>
> <br>
> Patch includes:<br>
> 1. Implementation<br>
> 2. Updated tests<br>
> 3. Update doc<br>
> <br>
> Regards,<br>
> Umar Hayat<br>
> EnterpriseDB: <a href="https://www.enterprisedb.com/" rel="noreferrer" target="_blank">https://www.enterprisedb.com/</a><br>
<br>
<br>
-- <br>
Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
SRA OSS, Inc. Japan<br>
</blockquote></div>
</blockquote></div></div>