<div dir="ltr"><div dir="ltr">Hi Ishii-San<div><br></div><div>Thanks for looking into this and for the confirmation regarding the extended query tests.</div><div><br></div><div>I have pushed the code reorganization and pcp_stop_pgpool enhancements as two</div><div>separate commits. </div><div><br></div><div>Best regards</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 4, 2020 at 11:37 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> Hi Usama,<br>
> <br>
>> Hi Ishii-San<br>
>> <br>
>> Thanks for looking into the patch and valuable feedback.<br>
>> <br>
>> Please find the V2 of the patch that fixes the mentioned issues<br>
>> except the extended-query-test produces, that is failing because the<br>
>> expected<br>
>> output was generated by some different version of PostgreSQL and now the<br>
>> line number in the expected notice messages are coming out from different<br>
>> line numbers of the PG code.<br>
> <br>
> No, the line number difference of the PG code has been already handled<br>
> in the test script:<br>
> <br>
> sed -e 's/L [0-9]*/L xxx/g' $expected/$i > expected_tmp<br>
> <br>
> This replaces the line number to 'xxx' so that the test ignores the<br>
> line number difference in the PG code.<br>
> <br>
> However I found that the test failures are actually caused by this<br>
> commit, not by your patches:<br>
> <br>
> <a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=eee4c86c03546abe4e33396c808c8425c23a443c" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=eee4c86c03546abe4e33396c808c8425c23a443c</a><br>
> <br>
> The extended query tests (actually scripts under "extra_scripts") rely<br>
> on the per_node_statements configuration parameter to print SQL<br>
> statements. Before those are only produced by Parse and Execute. With<br>
> commit now those are printed by not only Execute and Parse but<br>
> Bind. That's the cause of the test failure.<br>
> <br>
> Sorry for my misunderstanding and I am looking forward to taking care<br>
> of this part.<br>
<br>
I have pushed the fix.<br>
<br>
Now both regression test and extended query test are all green.<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div style="color:rgb(0,0,0)"><div><div><span style="color:rgb(68,68,68)">...<br></span></div><div><span style="color:rgb(68,68,68)">Muhammad Usama<br></span></div><div><span><span style="font-family:Lato"><span style="font-size:14px"><span style="color:rgb(68,68,68)">Highgo Software (Canada/China/Pakistan)</span><span><span style="color:rgb(68,68,68)"> </span></span></span></span></span><span style="color:rgb(68,68,68)"><br></span></div><div><span><span style="font-family:Lato"><span style="font-size:14px"><span style="color:rgb(68,68,68)">URL :</span><span><span style="color:rgb(68,68,68)"> </span></span></span></span></span><a href="http://www.highgo.ca/" style="color:rgb(89,143,222);font-family:Lato;font-size:14px" target="_blank"><span style="color:rgb(68,68,68)">http://www.highgo.ca</span></a><span><span style="font-family:Lato"><span style="font-size:14px"><span><span style="color:rgb(68,68,68)"> </span></span></span></span></span><span style="color:rgb(68,68,68)"><br></span></div><div><span><span style="font-family:Lato"><span style="font-size:14px"><span style="color:rgb(68,68,68)">ADDR: 10318 WHALLEY BLVD, Surrey, BC</span><span><span style="color:rgb(68,68,68)"> </span></span></span></span></span><br></div></div></div></div></div></div>