<div dir="ltr">Thanks Bo Peng. <div><br></div><div>Ishii-san,</div><div></div><div>Can you please move following to DONE in TODO wiki.</div><div><i style="color:rgb(0,0,0);white-space:pre-wrap"><a href="https://pgpool.net/mediawiki/index.php/TODO#Add_support_for_an_user/password_input_file_to_pg_md5">https://pgpool.net/mediawiki/index.php/TODO#Add_support_for_an_user/password_input_file_to_pg_md5</a></i><pre style="white-space:pre-wrap;color:rgb(0,0,0)">Thanks<br>Umar Hayat<br></pre></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 7, 2020 at 7:53 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp">pengbo@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thank you.<br>
<br>
Patch is committed.<br>
<a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=68d66a66f55099d7ef2fdf0e7fb48ba6577e98c3" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=68d66a66f55099d7ef2fdf0e7fb48ba6577e98c3</a><br>
<br>
On Mon, 30 Mar 2020 17:14:12 +0500<br>
Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
<br>
> Hi Usama,<br>
> Any feedback ?<br>
> <br>
> On Thu, Mar 19, 2020 at 7:07 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>> wrote:<br>
> <br>
> > Hello,<br>
> ><br>
> > On Wed, 18 Mar 2020 11:51:05 +0500<br>
> > Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
> ><br>
> > > Hi,<br>
> > > Please updated patch based on feedback from Tatsu Ishii on pg_enc patch.<br>
> ><br>
> > I tested your patch and it works fine.<br>
> ><br>
> > Usama,<br>
> ><br>
> > If you don't have any feedback, I am going to update<br>
> > the patch based on Ishii-san's feedback and commit it.<br>
> ><br>
> > > Regards<br>
> > > Umar Hayat<br>
> > ><br>
> > > On Tue, Mar 10, 2020 at 3:39 PM Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>><br>
> > wrote:<br>
> > ><br>
> > > > Any further updated needed for this patch from my end?<br>
> > > ><br>
> > > > Regards<br>
> > > > Umar Hayat<br>
> > > ><br>
> > > > On Thu, Mar 5, 2020 at 1:45 AM Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>><br>
> > wrote:<br>
> > > ><br>
> > > >> Hi Usama,<br>
> > > >> Thanks for feedback, updated patch is attached.<br>
> > > >> Please see comments inline.<br>
> > > >><br>
> > > >> Regards<br>
> > > >> Umar Hayat<br>
> > > >><br>
> > > >><br>
> > > >> On Wed, Mar 4, 2020 at 8:05 PM Muhammad Usama <<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>><br>
> > wrote:<br>
> > > >><br>
> > > >>> Hi Umar,<br>
> > > >>><br>
> > > >>> Here are some of the comments on your patch on top of Peng's<br>
> > comments.<br>
> > > >>><br>
> > > >>> 1- The patch breaks the -f short option, by removing the : (colon)<br>
> > after<br>
> > > >>> f from the optstring argument to getopt_long function<br>
> > > >>><br>
> > > >>> i.e<br>
> > > >>> while ((opt = getopt_long(argc, argv, "hpmfi:u:", long_options,<br>
> > > >>> &optindex)) != -1)<br>
> > > >>> should be<br>
> > > >>> while ((opt = getopt_long(argc, argv, "hpmf:i:u:", long_options,<br>
> > > >>> &optindex)) != -1)<br>
> > > >>><br>
> > > >> Fixed.<br>
> > > >><br>
> > > >>> 2- The input file has no option to specify escape characters. For<br>
> > > >>> example, there is no way to specify a user name or password<br>
> > > >>> in the input file that contains : (colon)<br>
> > > >>><br>
> > > >> It does handle colon in password as it consider only left most colon<br>
> > as<br>
> > > >> separator. For example for pair like 'user:pass:word', user name will<br>
> > be<br>
> > > >> 'user' and password will be 'pass:word'<br>
> > > >> I am not sure user name with colon is valid scenario? If its true, we<br>
> > can<br>
> > > >> add a note otherwise IMO there could be ton of negative scenarios.<br>
> > > >><br>
> > > >>> 3- Specifying the input file disregards the "-m" "--md5auth" option<br>
> > > >>><br>
> > > >>> Fixed. That was purposefully disregarded previously as mention<br>
> > > >> in mentisbt-422, input-file mode as only for md5auth.<br>
> > > >> Now It honour -m flag and in absence of this it will print md5 value<br>
> > > >> stdout.<br>
> > > >><br>
> > > >>> 4- The patch is not considering the length of username and password<br>
> > > >>> buffers while copying into them<br>
> > > >>><br>
> > > >>><br>
> > > >>> + strncpy(username, buf, pch-buf);<br>
> > > >>> + strncpy(password, pch+1, strlen(pch+1));<br>
> > > >>><br>
> > > >>><br>
> > > >>> The len (3rd) argument of strncpy is intended to guard against the<br>
> > > >>> buffer overflow of the destination string.<br>
> > > >>><br>
> > > >>> Fixed.<br>
> > > >><br>
> > > >>> Thanks<br>
> > > >>> Best regards<br>
> > > >>> Muhammad Usama<br>
> > > >>><br>
> > > >>><br>
> > > >>> On Wed, Mar 4, 2020 at 11:03 AM Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>><br>
> > > >>> wrote:<br>
> > > >>><br>
> > > >>>> Hi Bo Peng,<br>
> > > >>>> Please find updated patch with following changes.<br>
> > > >>>> 1. Trailing whitespaces warning removed<br>
> > > >>>> 2. Documentation added in "doc/src/sgml/ref/pg_md5.sgml" with<br>
> > options<br>
> > > >>>> update and example usage.<br>
> > > >>>><br>
> > > >>>> Regards,<br>
> > > >>>> Umar Hayat<br>
> > > >>>><br>
> > > >>>> On Wed, Mar 4, 2020 at 7:40 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>> wrote:<br>
> > > >>>><br>
> > > >>>>> hello,<br>
> > > >>>>><br>
> > > >>>>> On Tue, 3 Mar 2020 14:13:33 +0500<br>
> > > >>>>> Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
> > > >>>>><br>
> > > >>>>> > Hi Bo Peng,<br>
> > > >>>>> > Any feedback, If this looks ok to you? I should send the same for<br>
> > > >>>>> pg_enc<br>
> > > >>>>> > utility.<br>
> > > >>>>><br>
> > > >>>>> Sorry for late response.<br>
> > > >>>>><br>
> > > >>>>> First, when I apply this patch, I found some extra trailing spaces.<br>
> > > >>>>><br>
> > > >>>>> -----------------<br>
> > > >>>>> $ git apply pg_md5_input_file.diff<br>
> > > >>>>> pg_md5_input_file.diff:85: trailing whitespace.<br>
> > > >>>>> static void<br>
> > > >>>>> warning: 1 line adds whitespace errors.<br>
> > > >>>>> -----------------<br>
> > > >>>>><br>
> > > >>>>> Could you add documentation in "doc/src/sgml/ref/pg_md5.sgml" to<br>
> > > >>>>> explain how to use this option?<br>
> > > >>>>><br>
> > > >>>>> ><br>
> > > >>>>> > Regards<br>
> > > >>>>> > Umar Hayat<br>
> > > >>>>> > Principal Software Engineer<br>
> > > >>>>> > EnterpriseDB: <a href="https://www.enterprisedb.com" rel="noreferrer" target="_blank">https://www.enterprisedb.com</a><br>
> > > >>>>> ><br>
> > > >>>>> > On Thu, Feb 13, 2020 at 9:54 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
> > wrote:<br>
> > > >>>>> ><br>
> > > >>>>> > > Thank you for your patch.<br>
> > > >>>>> > > I will review your patch.<br>
> > > >>>>> > ><br>
> > > >>>>> > > On Tue, 11 Feb 2020 16:45:50 +0500<br>
> > > >>>>> > > Umar Hayat <<a href="mailto:m.umarkiani@gmail.com" target="_blank">m.umarkiani@gmail.com</a>> wrote:<br>
> > > >>>>> > ><br>
> > > >>>>> > > > Hello Hackers,<br>
> > > >>>>> > > ><br>
> > > >>>>> > > > I saw "Add support for an user/password input file to pg_md5"<br>
> > > >>>>> enhancement<br>
> > > >>>>> > > > in PgPool-II TODO list<br>
> > > >>>>> > > > <<br>
> > > >>>>> > ><br>
> > > >>>>><br>
> > <a href="https://pgpool.net/mediawiki/index.php/TODO#Add_support_for_an_user/password_input_file_to_pg_md5" rel="noreferrer" target="_blank">https://pgpool.net/mediawiki/index.php/TODO#Add_support_for_an_user/password_input_file_to_pg_md5</a><br>
> > > >>>>> > > >,<br>
> > > >>>>> > > > (mentisbt-422 <<br>
> > <a href="https://www.pgpool.net/mantisbt/view.php?id=422" rel="noreferrer" target="_blank">https://www.pgpool.net/mantisbt/view.php?id=422</a>>),<br>
> > > >>>>> so I<br>
> > > >>>>> > > > implemented this in pg_md5 utility. Please find attached<br>
> > patch<br>
> > > >>>>> for<br>
> > > >>>>> > > > enhancement.<br>
> > > >>>>> > > ><br>
> > > >>>>> > > > As suggested, a new --input-file option added in pg_md5.<br>
> > Using<br>
> > > >>>>> this<br>
> > > >>>>> > > option,<br>
> > > >>>>> > > > pg_md5 will parse the *user:password* pairs from provide file<br>
> > > >>>>> and will<br>
> > > >>>>> > > > create *user:md5xxxxxx* value in pool_passwd file.<br>
> > > >>>>> > > ><br>
> > > >>>>> > > > Regards,<br>
> > > >>>>> > > > Umar Hayat<br>
> > > >>>>> > ><br>
> > > >>>>> > ><br>
> > > >>>>> > > --<br>
> > > >>>>> > > Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
> > > >>>>> > > SRA OSS, Inc. Japan<br>
> > > >>>>> > ><br>
> > > >>>>><br>
> > > >>>>><br>
> > > >>>>> --<br>
> > > >>>>> Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
> > > >>>>> SRA OSS, Inc. Japan<br>
> > > >>>>><br>
> > > >>>> _______________________________________________<br>
> > > >>>> pgpool-hackers mailing list<br>
> > > >>>> <a href="mailto:pgpool-hackers@pgpool.net" target="_blank">pgpool-hackers@pgpool.net</a><br>
> > > >>>> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
> > > >>>><br>
> > > >>><br>
> ><br>
> ><br>
> > --<br>
> > Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
> > SRA OSS, Inc. Japan<br>
> ><br>
<br>
<br>
-- <br>
Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
SRA OSS, Inc. Japan<br>
</blockquote></div>