<div dir="ltr"><font face="verdana, sans-serif">Hi Hackers</font><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">As different packages of Pgpool-II like Debian and rpm require different default paths for placing the UNIX domain socket files. But the problem is that, even if we mention that in the pgpool.conf sample files ( using some patch or manual editing before creating the package) the actual code still considers the &#39;<i>/tmp</i>&#39; (that is hardcoded in the source) as a default socket directory path, which is not right and confusing. Especially in case of PCP utilities as they still try to locate the socket in <i>&#39;/tmp&#39;</i> (because they have no idea about pgpool.conf settings).</font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">So I was thinking of making the default socket directory path configurable and created a patch for that. The patch adds a new configuration switch &quot;<span style="font-variant-ligatures:no-common-ligatures;color:rgb(0,0,0);font-size:12px">--with-default-socket-dir&quot; </span></font></div><div><span style="font-variant-ligatures:no-common-ligatures;color:rgb(0,0,0);font-size:12px"><font face="verdana, sans-serif">that can be used to change the default path where Pgpool-II and its utility will look for the socket files.</font></span></div><div><span style="font-variant-ligatures:no-common-ligatures;color:rgb(0,0,0);font-size:12px"><font face="verdana, sans-serif">On top of that, the configure also automatically modifies all the pgpool.conf.sample* files to reflect the new default path. </font></span></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">For example, if for Debian packaging we want to use the <i>&#39;</i><span style="color:rgba(0,0,0,0.85);font-size:12px"><i>/var/run/postgresql&#39;</i> as the default directory for Unix domain</span></font></div><div><font face="verdana, sans-serif"><span style="color:rgba(0,0,0,0.85);font-size:12px">sockets we can just set the path during configure step</span></font></div><div><span style="color:rgba(0,0,0,0.85);font-size:12px"><font face="verdana, sans-serif"><br></font></span></div><div>

















<p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)"><font face="monospace"><span style="font-variant-ligatures:no-common-ligatures;color:rgb(0,0,0)">[usama@62c5 pgpool2]# </span><span style="font-variant-ligatures:no-common-ligatures;color:rgb(0,0,0)">./configure .. --with-default-socket-dir=</span>/var/run/postgresql</font></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)"><font face="verdana, sans-serif"><br></font></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)"><font face="verdana, sans-serif">This will not only change the source code to use the <i>&#39;/var/run/postgresql&#39;</i> path as default</font></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)"><font face="verdana, sans-serif">but will also change the sample conf files as well.</font></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)"><font face="verdana, sans-serif"><br></font></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="verdana, sans-serif">-- After configure with --</font></span><span style="font-size:small;color:rgb(34,34,34)">with-default-socket-dir option</span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span style="font-size:small;color:rgb(34,34,34)"><br></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">git diff src/sample/pgpool.conf.sample-stream<span class="gmail-Apple-converted-space" style=""> </span></font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">diff --git a/src/sample/pgpool.conf.sample-stream b/src/sample/pgpool.conf.sample-stream</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">index ef20c0f..7587d22 100644</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">--- a/src/sample/pgpool.conf.sample-stream</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">+++ b/src/sample/pgpool.conf.sample-stream</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">@@ -31,7 +31,7 @@ listen_addresses = &#39;localhost&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space"> </span>port = 9999</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># Port number</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># (change requires restart)</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">-socket_dir = &#39;/tmp&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">+socket_dir = &#39;/var/run/postgresql&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># Unix domain socket path</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># The Debian package defaults to</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># /var/run/postgresql</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">@@ -51,7 +51,7 @@ pcp_listen_addresses = &#39;*&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space"> </span>pcp_port = 9898</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># Port number for pcp</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># (change requires restart)</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">-pcp_socket_dir = &#39;/tmp&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">+pcp_socket_dir = &#39;/var/run/postgresql&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># Unix domain socket path for pcp</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># The Debian package defaults to</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                    </span># /var/run/postgresql</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">@@ -581,7 +581,7 @@ wd_authkey = &#39;&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                     </span># Authentication key for watchdog communication</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                     </span># (change requires restart)</font></span></p><p class="gmail-p2" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0);min-height:18px"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><span class="gmail-Apple-converted-space"><font face="monospace"> </font></span></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">-wd_ipc_socket_dir = &#39;/tmp&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace">+wd_ipc_socket_dir = &#39;/var/run/postgresql&#39;</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                     </span># Unix domain socket path for watchdog IPC socket</font></span></p><p class="gmail-p1" style="margin:0px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                     </span># The Debian package defaults to</font></span></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgba(0,0,0,0.85)">




































</p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:12px;line-height:normal;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><font face="monospace"><span class="gmail-Apple-converted-space">                                     </span># /var/run/postgresql</font></span></p></div>





<div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">The main idea of this patch is to make the packaging of Pgpool-II easier and more consistent.</font></div><div><font face="verdana, sans-serif">Thoughts and suggestions?<br></font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif">Thanks</font></div><div><font face="verdana, sans-serif">Best Regards</font></div><div><font face="verdana, sans-serif">Muhammad Usama</font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif"><br></font></div><div><font face="verdana, sans-serif"><br></font></div><div><br></div></div>