<div dir="ltr"><div>Hi Ishii-San</div><div><br></div>Thanks for pointing out the missing test case patch, I have committed the patch after making a few<div>minor changes, mostly the changes are related to the documentation part and also I have changed</div><div>the configuration parameter name to "enable_consensus_with_half_votes".</div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 29, 2019 at 3:37 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> Hi Usama,<br>
> <br>
>> Hi Ishii-San,<br>
>> <br>
>> The patch looks good overall, but I have few observations.<br>
>> <br>
>> First I don't think we needed the changes in the<br>
>> get_mimimum_nodes_required_for_quorum()<br>
>> function, Since the function, returns the int so the change are no-op I<br>
>> believe.<br>
>> <br>
>> Also, I think we need kind of similar changes in<br>
>> compute_failover_consensus() where we are checking<br>
>> if we have got enough votes for failover as we have done in<br>
>> update_quorum_status() function.<br>
>> <br>
>> So I have updated your patch a little bit. Can you see if the changes I<br>
>> made looks good to you?<br>
> <br>
> Thanks. I will look into this.<br>
<br>
For me your patch works as expected. However it seems you forgot to<br>
patch regression test 004.watchdog, which I already proposed in<br>
upthread. Patch reattached.<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
</blockquote></div></div></div></div>