<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 7:04 PM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> On Mon, May 27, 2019 at 10:25 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
> <br>
>> > Hello, Usama and pgpool-hackers<br>
>> ><br>
>> > Thank you very much for writing and committing patches to solve the issue<br>
>> > that I reported.<br>
>> ><br>
>> > What do you think about back-patching them into 3.7.x or older versions?<br>
>> > Pgpool-II watchdog cluster can easily fall into the status that doesn't<br>
>> > work without the patch.<br>
>> ><br>
>> > The quarantine feature hasn't been documented in detail up to now, so<br>
>> > I think the behavior change of the first patch (*1) has no problem.<br>
>> > My customer who has trouble related to this mail thread uses 3.7.x<br>
>> version<br>
>> > and strongly hopes such a pgpool improvement.<br>
>> ><br>
>> > *1<br>
>> ><br>
>> <a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=3dd1cd3f1528" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=3dd1cd3f1528</a><br>
>><br>
>> We know that this patch breaks existing regression test. So I don't<br>
>> think no user would notice the behavior change if the patch is<br>
>> back ported.<br>
>><br>
> <br>
> I sort of agree with Takatsuka San, that the continuous health checking on<br>
> the quarantined backed nodes (first patch)<br>
> is not the kind of change that should cause problems if we decide to<br>
> backport it to older branches, In fact. it should be treated<br>
> as a bug and back-patched to all affected branches. Also, the reason for<br>
> the test case failure happening after that commit<br>
> was not because of the behaviour or functionality change. rather it was due<br>
> to the missing facility in health-check<br>
> debugging/testing mechanism which was required by that test case after the<br>
> change.<br>
<br>
Alright. Then let's back port the firsr patch.<br></blockquote><div><br></div><div>I have backported the committ till Pgpool-II 3.7 </div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
</blockquote></div></div>