<div dir="ltr">Added docs change (for english only) and formatted as suggested.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">ср, 7 серп. 2019 о 10:17 Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> пише:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> The pool_passwd option [1] is specified relative to config file. But for<br>
> greater flexibility absolute path should be accepted as well.<br>
> <br>
> If pool_passwd option starts with /, let's treat it as absolute path.<br>
> Otherwise, it is treated as relative path.<br>
> <br>
> Patch attached. Original author - Derek Kulinski [2]. In NixOS,<br>
> configuration files often end up in world readable store, which is not the<br>
> best place for storing password files.<br>
<br>
Would it be possible for you to provide documentation (SGML files) patch?<br>
<br>
One small point:<br>
<br>
This does not follow PostgreSQL coding standard (we follow it):<br>
<br>
dirp, pool_config->pool_passwd);<br>
} else<br>
strlcpy(pool_passwd, pool_config->pool_passwd,<br>
sizeof(pool_passwd));<br>
<br>
This should be:<br>
<br>
dirp, pool_config->pool_passwd);<br>
}<br>
else<br>
strlcpy(pool_passwd, pool_config->pool_passwd,<br>
sizeof(pool_passwd));<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
</blockquote></div>