<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 12:51 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> Hi Ishii San<br>
> <br>
> <br>
> <br>
> On Thu, May 30, 2019 at 3:46 PM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
> <br>
>> Usama,<br>
>><br>
>> Are you going to add new parameter for this? I vaguely recall that we<br>
>> agreed to add a new parameter for this in a telephone discussion.<br>
>><br>
> <br>
> I am sorry somehow I might have missed that discussion and couldn't recall<br>
> it :-(<br>
> <br>
> Are you of the point of view that we should make the behavior optional by<br>
> adding<br>
> a config parameter to control it?<br>
<br>
Yes, I am. The change is rather big one, and it'd be best to give a<br>
chance to keep the existing behavior or not.<br></blockquote><div><br></div><div>Sure, I second you on that, it's a big behavioral change and must be configurable.</div><div><br></div><div>I will draft and share a patch for that.</div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> Thanks<br>
> Best regards<br>
> Muhammad Usama<br>
> <br>
> <br>
> <br>
>><br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> From: Muhammad Usama <<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>><br>
>> Subject: [pgpool-committers: 5790] pgpool: Second part for<br>
>> [pgpool-hackers: 3295] duplicate failover reque<br>
>> Date: Sun, 26 May 2019 21:37:58 +0000<br>
>> Message-ID: <<a href="mailto:E1hV0q6-0000rS-OH@gothos.postgresql.org" target="_blank">E1hV0q6-0000rS-OH@gothos.postgresql.org</a>><br>
>><br>
>> > Second part for [pgpool-hackers: 3295] duplicate failover request ...fix<br>
>> ><br>
>> > As per the discussion on the thread [pgpool-hackers: 3295] we came to the<br>
>> > conclusion, that the master watchdog node should resign from master<br>
>> > responsibilities if the primary backend node gets into quarantine state<br>
>> on that.<br>
>> ><br>
>> > The commit implements the said behaviour by making the<br>
>> master/coordinator watchdog<br>
>> > node resign from its status if it fails to get the consensus for the<br>
>> quarantined<br>
>> > primary node failover, with in FAILOVER_COMMAND_FINISH_TIMEOUT(15)<br>
>> seconds.<br>
>> ><br>
>> > When the watchdog master resigns, because of quarantined primary node its<br>
>> > wd_priority is decreased to (-1), so that it should get the least<br>
>> preference<br>
>> > in the next election for the master/coordinator node selection. And once<br>
>> the<br>
>> > election is concluded the wd_priority for the node gets restored to the<br>
>> > original configured value.<br>
>> ><br>
>> > In case of failed consensus for standby node failover no action is taken.<br>
>> ><br>
>> > Branch<br>
>> > ------<br>
>> > master<br>
>> ><br>
>> > Details<br>
>> > -------<br>
>> ><br>
>> <a href="https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=33df0d33df1ce701f07fecaeef5b87a2707c08f2" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=33df0d33df1ce701f07fecaeef5b87a2707c08f2</a><br>
>> ><br>
>> > Modified Files<br>
>> > --------------<br>
>> > src/watchdog/watchdog.c | 47<br>
>> +++++++++++++++++++++++++++++++++++++++++++++--<br>
>> > 1 file changed, 45 insertions(+), 2 deletions(-)<br>
>> ><br>
>><br>
</blockquote></div></div>