<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 17, 2019 at 9:17 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp">pengbo@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Usama,<br>
<br>
Thank you for your patch.<br>
<br>
Yugo testet your patch, and give us some feedbacks.<br>
Could you test the patch again?<br>
<br>
<a href="https://www.pgpool.net/mantisbt/view.php?id=455" rel="noreferrer" target="_blank">https://www.pgpool.net/mantisbt/view.php?id=455</a><br>
<br></blockquote><div><br></div><div>Sorry my bad, Yugo's patch is correct,</div><div>I figured out the mistake, fixed that and actually tested with the correct version </div><div>but unfortunately somehow attached the wrong patch file in the mail :-(</div><div><br></div><div>Thanks</div><div>Best Regards</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On Mon, 14 Jan 2019 19:12:48 +0500<br>
Muhammad Usama <<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>> wrote:<br>
<br>
> Hi Ishii-San<br>
> <br>
> On Fri, Jan 11, 2019 at 5:30 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
> <br>
> > > Hi Ishii-San<br>
> > ><br>
> > > On Thu, Jan 10, 2019 at 11:52 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>><br>
> > wrote:<br>
> > ><br>
> > >> It is pointed out that watchdog lifecheck method with query mode does<br>
> > >> not work since 4.0.<br>
> > >><br>
> > >> <a href="https://www.pgpool.net/mantisbt/view.php?id=455" rel="noreferrer" target="_blank">https://www.pgpool.net/mantisbt/view.php?id=455</a><br>
> > >><br>
> > >> The cause of this is using thread unsafe function<br>
> > >> get_pgpool_config_user_password(). Making it thread safe requires none<br>
> > >> trivial work. So I tend to agree that we disable using AES encrypted<br>
> > >> password for lifecheck method = "query".<br>
> > >><br>
> > >><br>
> > > Yes that's true, making get_pgpool_config_user_password thread safe would<br>
> > > be lot of work.<br>
> > > I am thinking what if change the code and call<br>
> > > get_pgpool_config_user_password() from outside the thread function before<br>
> > > creating<br>
> > > the threads and pass in the password as the argument to the thread<br>
> > > function. This way we can keep supporting the AES encrypted<br>
> > > password for lifecheck method = "query"<br>
> ><br>
> > Sounds a nice idea. Can you please come up with a propose patch?<br>
> ><br>
> <br>
> Please find the attached patch which takes the<br>
> get_pgpool_config_user_password()<br>
> function outside the thread, as discussed upthread.<br>
> <br>
> Thanks<br>
> Best Regards<br>
> Muhammad Usama<br>
> <br>
> <br>
> > Best regards,<br>
> > --<br>
> > Tatsuo Ishii<br>
> > SRA OSS, Inc. Japan<br>
> > English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
> > Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
> ><br>
<br>
<br>
-- <br>
Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
SRA OSS, Inc. Japan<br>
<br>
</blockquote></div></div>