<div dir="ltr">Hi<div><br></div><div>Please find the attached patch to fix the pool_passwd file corruption issue pointed out by Jesper.</div><div>Along with the corruption fix I have also made some changes to how pool_passwd file is read, previously</div><div>we used to open this file at the startup time and keep the file descriptor opened for the whole lifecycle.</div><div>Now with this patch I have modified this behaviour and the pool_passwd is only opened when it is needed and</div><div>closed afterwards.</div><div><br></div><div>Am I missing something obvious here or do you agree with this change.</div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 22, 2018 at 8:41 AM Bo Peng <<a href="mailto:pengbo@sraoss.co.jp">pengbo@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jesper,<br>
<br>
Thank you for reporting this issue.<br>
We will fix it.<br>
<br>
On Fri, 19 Oct 2018 07:08:51 -0400<br>
Jesper Pedersen <<a href="mailto:jesper.pedersen@redhat.com" target="_blank">jesper.pedersen@redhat.com</a>> wrote:<br>
<br>
> Hi,<br>
> <br>
> On 10/3/18 10:36 AM, Tatsuo Ishii wrote:<br>
> >> On 8/24/18 7:46 AM, Jesper Pedersen wrote:<br>
> >>>> Please add items if I missed something.<br>
> >>> 7) 0000419: pg_md5: -m removes users<br>
> >>> - <a href="https://www.pgpool.net/mantisbt/view.php?id=419" rel="noreferrer" target="_blank">https://www.pgpool.net/mantisbt/view.php?id=419</a><br>
> >><br>
> >> This will make its way into 4.0.0, correct ?<br>
> > <br>
> > I believe so. Please let me know if you find any problem with pg_md5.<br>
> > <br>
> <br>
> So, this made its way into 4.0.0 which will corrupt pool_passwd;<br>
> <br>
> pg_md5 -f conf/pgpool.conf -u user1 -m user1<br>
> pg_md5 -f conf/pgpool.conf -u user2 -m user2<br>
> pg_md5 -f conf/pgpool.conf -u user3 -m user3<br>
> <br>
> cat conf/pgpool.conf<br>
> user1:md57d1b5a4329b6478e976508ab9a49ee3d<br>
> user2:md572881e285cdb0f9370dcdf1db0d9a869<br>
> user3:md516bd93afc66e593f3aeedecdf1201ee6<br>
> <br>
> pg_enc -f conf/pgpool.conf -u user1 -m user1<br>
> <br>
> cat conf/pgpool.conf<br>
> user1:AES1MLVcB4ex/cCqL24k1H8wQ==<br>
> a49ee3d<br>
> user2:md572881e285cdb0f9370dcdf1db0d9a869<br>
> user3:md516bd93afc66e593f3aeedecdf1201ee6<br>
> <br>
> pg_enc -f conf/pgpool.conf -u user2 -m user2<br>
> <br>
> cat conf/pgpool.conf<br>
> user1:AES1MLVcB4ex/cCqL24k1H8wQ==<br>
> a49ee3d<br>
> user2:md572881e285cdb0f9370dcdf1db0d9a869<br>
> user3:md516bd93afc66e593f3aeedecdf1201ee6<br>
> user2:AESFndsqgtIUnJSEr0yn1cTQA==<br>
> <br>
> <br>
> Pending patches:<br>
> <br>
> <a href="http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/002955.html" rel="noreferrer" target="_blank">http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/002955.html</a><br>
> <a href="http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003017.html" rel="noreferrer" target="_blank">http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003017.html</a><br>
> <a href="http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003025.html" rel="noreferrer" target="_blank">http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003025.html</a><br>
> <br>
> Best regards,<br>
> Jesper<br>
> _______________________________________________<br>
> pgpool-hackers mailing list<br>
> <a href="mailto:pgpool-hackers@pgpool.net" target="_blank">pgpool-hackers@pgpool.net</a><br>
> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
<br>
<br>
-- <br>
Bo Peng <<a href="mailto:pengbo@sraoss.co.jp" target="_blank">pengbo@sraoss.co.jp</a>><br>
SRA OSS, Inc. Japan<br>
<br>
_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net" target="_blank">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</blockquote></div>