<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sat, Aug 18, 2018 at 5:07 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Usama,<br>
<br>
> Hi Ishii-San<br>
> <br>
> Please find the attached patch to fix mistakes where "fail_over" and<br>
> "fail-over" were used instead of the "failover". And that also includes a<br>
> wrongly spelled configuration parameter "fail_over_on_backend_error",<br>
> The patch throws the warning message when old config name<br>
> fail_over_on_backend_error is used instead of failover_on_backend_error and<br>
> suggests to use the correct name, while using the old config variable name<br>
> has no effect.<br>
> <br>
> What do you think of the approach to throw a waring message and making the<br>
> old variable name ineffective.<br>
<br>
Looks good to me.<br></blockquote><div><br></div><div>Thanks for the review, I have pushed it to master branch.</div><div><br></div><div>Kind regards</div><div>Muhammad Usama</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
</blockquote></div></div>