<div dir="ltr">Hi Ishii-San<div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 13, 2018 at 5:36 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Usama,<br>
<br>
In this commit, new function pool_set_backend_status_changed_time() is<br>
added to update the last status change time stamp. However I am not so<br>
sure about the correct timing to call it within watchdog modules. I<br>
would appreciate if you take a look at them in this regard.<br></blockquote><div><br></div><div>Sure,<span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"> I'll take a look. </span><br style="text-decoration-style:initial;text-decoration-color:initial"> </div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
From: Muhammad Usama <<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>><br>
Subject: Re: [pgpool-hackers: 2825] Re: Proposal: Add last state change timestamp to "show pool_nodes"<br>
Date: Tue, 12 Jun 2018 18:18:14 +0500<br>
Message-ID: <CAEJvTzXnphb=<a href="mailto:ZHY9qUenqUOWVGJ2X2dpyk9qHYjon%2BN4Fckq6w@mail.gmail.com" target="_blank">ZHY9qUenqUOWVGJ2X2dpyk9qHYjon+N4Fckq6w@mail.gmail.com</a>><br>
<br>
> On Tue, Jun 12, 2018 at 5:59 PM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
> <br>
>> Ok, I have done. The new column name is "last_status_change" as<br>
>> suggested. However pcp_node_info and pgpool_adm are not updated yet.<br>
>><br>
>> Many thanks :-)<br>
> <br>
> Best Regards<br>
> Muhammad Usama<br>
> <br>
> <br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> > Hi Ishii-San,<br>
>> ><br>
>> > On Tue, Jun 12, 2018 at 5:47 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>> wrote:<br>
>> ><br>
>> >> Hi Usama,<br>
>> >><br>
>> >> > Hi Ishii-San<br>
>> >> ><br>
>> >> > Thanks for the patch and I totally second the Peng's comment that it<br>
>> is a<br>
>> >> > very useful feature<br>
>> >> > to have and will have many practical use cases.<br>
>> >> > I have couple of small comments on the attached patch<br>
>> >> > One is I think it would be good idea to also include this last status<br>
>> >> > changed column in pcp_node_info's output.<br>
>> >><br>
>> >> If we do that we need to maintain pgpool_adm as well. Pgpool_adm is<br>
>> >> already far behind from current pcp_node_info implementation since<br>
>> >> pgpool_adm lacks "backend role" column.<br>
>> >><br>
>> >><br>
>> > Yes that is one issue, and I believe we need to plan out something for<br>
>> > Pgpool-adm<br>
>> > enhancement to bring it upto Pgpool core version.<br>
>> > I am just thinking Is it possible if we add the last_status_change<br>
>> column<br>
>> > in pcp_node_info<br>
>> > but Pgpool_adm keep ignoring it until it is updated<br>
>> ><br>
>> ><br>
>> ><br>
>> >> > and secondly what do you think about renaming the "status_changed"<br>
>> column<br>
>> >> > name to "last status change" in<br>
>> >> > show pool_nodes output?<br>
>> >><br>
>> >> Maybe but "last status change" is not appropreate column name. It<br>
>> >> should be "last_status_change" or something like that.<br>
>> >><br>
>> ><br>
>> > Sorry for the type. I actually meant "last_status_change" :-)<br>
>> ><br>
>> > Thanks<br>
>> > Best regards<br>
>> > Muhammad Usama<br>
>> ><br>
>> >><br>
>> >> > Thanks<br>
>> >> > Best Regards<br>
>> >> > Muhammad Usama<br>
>> >> ><br>
>> >> ><br>
>> >> > On Mon, Jun 11, 2018 at 7:14 PM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>><br>
>> wrote:<br>
>> >> ><br>
>> >> >> > Hi Ishii-san,<br>
>> >> >> ><br>
>> >> >> > I think this will be useful to show the last state change<br>
>> timestamp.<br>
>> >> >><br>
>> >> ><br>
>> >> > Totally agree. This will be a very useful feature to have.<br>
>> >> ><br>
>> >> >><br>
>> >> >> Thanks. Attached is a patch to implement this. Still documentations<br>
>> >> >> need to be updated.<br>
>> >> >><br>
>> >> >> > When pgpool-II starts, the timestamp is set to time the startup<br>
>> >> >> > time. After that whenever the status is changed, time timestamp is<br>
>> >> >> > recorded and shown.<br>
>> >> >><br>
>> >> >> Here "status" means not only "up" and "down" etc. but primary node<br>
>> >> >> changes. For example suppose there are two nodes 0 (primary) and 1<br>
>> >> >> (standby). If node 0 goes down and node 1 is promoted to primary, the<br>
>> >> >> time stamp of node 1 is updated. Though the up/down status of node 1<br>
>> >> >> is not changed (up->up), it becomes primary from standby.<br>
>> >> >><br>
>> >> >> Here is an example output of "show pool_nodes".<br>
>> >> >><br>
>> >> >> test=# show pool_nodes;<br>
>> >> >> -[ RECORD 1 ]-----+--------------------<br>
>> >> >> node_id | 0<br>
>> >> >> hostname | /tmp<br>
>> >> >> port | 11002<br>
>> >> >> status | up<br>
>> >> >> lb_weight | 0.500000<br>
>> >> >> role | standby<br>
>> >> >> select_cnt | 0<br>
>> >> >> load_balance_node | true<br>
>> >> >> replication_delay | 0<br>
>> >> >> status_changed | 2018-06-11 23:11:45<br>
>> >> >> -[ RECORD 2 ]-----+--------------------<br>
>> >> >> node_id | 1<br>
>> >> >> hostname | /tmp<br>
>> >> >> port | 11003<br>
>> >> >> status | up<br>
>> >> >> lb_weight | 0.500000<br>
>> >> >> role | primary<br>
>> >> >> select_cnt | 0<br>
>> >> >> load_balance_node | false<br>
>> >> >> replication_delay | 0<br>
>> >> >> status_changed | 2018-06-11 23:11:45<br>
>> >> >><br>
>> >> >> Best regards,<br>
>> >> >> --<br>
>> >> >> Tatsuo Ishii<br>
>> >> >> SRA OSS, Inc. Japan<br>
>> >> >> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> >> >> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>> >> >> _______________________________________________<br>
>> >> >> pgpool-hackers mailing list<br>
>> >> >> <a href="mailto:pgpool-hackers@pgpool.net" target="_blank">pgpool-hackers@pgpool.net</a><br>
>> >> >> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
>> >> >><br>
>> >><br>
>><br>
</blockquote></div></div></div>