<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 20, 2017 at 5:12 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Usama,<br>
<br>
Thanks for the patch.<br>
<br>
I think this is good since we didn't define the behavior when a<br>
relative path is specified for pid_file_name anyway. Now it's defined,<br>
which is good.<br></blockquote><div><br></div><div>Thanks</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Just out of curiosity, is there any use case to define the path of<br>
pid_file_name relative to the path of pgpool.conf? Since most users<br>
(and Linux systems) want to put pid_file_name under /var while they<br>
want to put pgpool.conf under /etc.<br></blockquote><div><br></div><div>Well the main motivation behind this pid_file_name change was to solve the confusion, since it has also confused me few times, and it is easy to get it wrong.</div><div>And I was thinking it as a step towards making the pgpool configurations self contained,</div><div>Like for example if we define the behaviour of each path related configuration parameter in the pgpool.conf than we would be able to copy paste the pgpool directory to different path or system and will be able to run the pgpool without modifying the pgpool.conf file, This feature would be useful in for certain lab /cloud environments, but yes its still someway to go to achieve that.</div><div><br></div><div>And as for now, I think you are right most of the users use /var for pid file and /etc for config and there may exist a very few use cases for this currently. </div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div> </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
<br>
> Hi Ishii-San<br>
><br>
> Can you please have a look at the attached patch.<br>
> The reason I want your consent before committing it is because apart from<br>
> using the absolute paths for pgpool.conf, pcp.conf and pool_hba.conf files,<br>
> I have also modified the behaviour of pid_file_name configuration parameter.<br>
> Now when the relative path is specified for the pid file in pgpool.conf<br>
> file that relative path is calculated with reference to the location of<br>
> pgpool.conf file.<br>
><br>
> For example:<br>
><br>
> if pgpool.conf file sets pid_file_name parameter as<br>
><br>
> pid_file_name = 'somedir/pgpool.pid'<br>
><br>
> And pgpool.conf file is located in the "/etc/configurations/" directory<br>
> than the Pgpool-II will create the pgpool.pid file<br>
> in "/etc/configurations/somedir" directory<br>
><br>
> While if absolute path is specified than it will work as it works before<br>
><br>
> pid_file_name = '/etc/mydir/pgpool.pid' # this will create the pgpool.pid<br>
> in /etc/mydir/ directory<br>
><br>
><br>
> I have done this change because I think it will make the configuration of<br>
> pid_file_name more intuitive and less confusing.<br>
> P.S The documentation changes are also part of the patch.<br>
><br>
> Thoughts and comments?<br>
><br>
><br>
> Thanks<br>
> Best regards<br>
> Muhammad Usama<br>
><br>
><br>
><br>
> On Wed, Jun 14, 2017 at 3:27 AM, Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br>
><br>
>> Good catch! Please go ahead.<br>
>><br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
>><br>
>> > Hi<br>
>> ><br>
>> > Pgpool-II does not properly handle the relative paths especially when the<br>
>> > pgpool.conf file is explicitly specified using the command line (-f<br>
>> switch)<br>
>> > while its patch is given relative to the current directory.<br>
>> ><br>
>> > For example:<br>
>> ><br>
>> > Suppose we invoke pgpool-II from "/home/work/installed/pgpool/<wbr>bin"<br>
>> directory<br>
>> ><br>
>> > $ pwd<br>
>> > /home/work//installed/pgpool/<wbr>bin<br>
>> > $ ./pgpool -f simple_conf/pgpool.conf<br>
>> ><br>
>> > Now we are expecting here is that the Pgpool-II will look for pgpool.conf<br>
>> > file in the<br>
>> > /home/work/installed/pgpool/<wbr>bin/simple_conf/ directory, which it does<br>
>> > correctly :-), and also latter in the startup phase when it will require<br>
>> > the pool_passwd file it will look in the same (<br>
>> > /home/work/installed/pgpool/<wbr>bin/simple_conf/)directory.<br>
>> > So in the code what Pgpool-II does is, it take out the directory portion<br>
>> > from the command line option provided to it for specifying the<br>
>> pgpool.conf<br>
>> > file and look for the pool_passwd file in that directory. which in this<br>
>> > case is just simple_conf/<br>
>> ><br>
>> > Now the problem here is since the pgpool.conf path used in the command<br>
>> line<br>
>> > option was a relative path, so it will only be able to go to the correct<br>
>> > directory location if the current directory of Pgpool-II remains the same<br>
>> > from where it was invoked from.<br>
>> ><br>
>> > And since we do not change the current directory when Pgpool-II is<br>
>> started<br>
>> > with "-n" switch ( non daemon mode) so everything works as expected in<br>
>> that<br>
>> > mode.<br>
>> > But when the Pgpool-II is started in the daemon mode the daemonize()<br>
>> > function changes the current directory to "/"<br>
>> ><br>
>> > main.c:380 if(chdir("/"))<br>
>> ><br>
>> > and after that all relative path becomes invalid and Pgpool-II will start<br>
>> > looking for files in invalid or non-existent location. which as per our<br>
>> > example in daemon mode it will try to find the pool_passwd file in<br>
>> ><br>
>> > /simple_conf/pool_passed<br>
>> ><br>
>> > instead of<br>
>> ><br>
>> > /home/work//installed/pgpool/<wbr>bin/simple_conf/pool_passwd<br>
>> > The solution to this is to convert the relative path of the pgpool.conf<br>
>> to<br>
>> > the absolute path at the startup and later use that absolute path for all<br>
>> > other path calculations.<br>
>> ><br>
>> > If you do not have any reservation, than I will start working on the fix.<br>
>> ><br>
>> > Thanks<br>
>> > Best Regards<br>
>> > Muhammad Usama<br>
>><br>
</div></div></blockquote></div><br></div></div>