<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 28, 2017 at 11:43 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Usama,<br>
<span class="gmail-"><br>
>> > I think you need to delete *src/config/pool_config.c* and<br>
>> > *src/tools/pgmd5/pool_config.<wbr>c* autogenerated files before building the<br>
>> > Pgpool-II, The reason being the memory for POOL_CONFIG->health_check_<br>
>> params<br>
>> > is allocated in pgpool_config.l and apparently the make is not<br>
>> regenerating<br>
>> > the pgpool_config.c.<br>
>><br>
>> Oh, I totaly forget about it. Will try again...<br>
<br>
</span>A quick test shows that your patches work pretty well.<br>
<span class="gmail-"><br>
>> > I was also wondering that we could use the array for health_check_params<br>
>> in<br>
>> > POOL_CONFIG rather than a pointer and allocating it dynamically.<br>
>><br>
>> But it requires health_check_params * MAX_NUM_BACKENDS (=128 for now)<br>
>> memory. Sounds like waste of meory...<br>
>><br>
><br>
> Yes true, But we are already allocating the same amount of memory<br>
> dynamically.<br>
<br>
</span>Oh, you are right. I thought we allocate<br>
health_check_params*NUM_<wbr>BACKENS memory but we actually allocate<br>
health_check_params * MAX_NUM_BACKENDS, since we cannot determine the<br>
value of NUM_BACKENDS until we finish parse the conf file.<br>
<br>
BTW,<br>
<span class="gmail-"><br>
>> > I think you need to delete *src/config/pool_config.c* and<br>
>> > *src/tools/pgmd5/pool_config.<wbr>c* autogenerated files before building the<br>
>> > Pgpool-II, The reason being the memory for POOL_CONFIG->health_check_<br>
>> params<br>
>> > is allocated in pgpool_config.l and apparently the make is not<br>
>> regenerating<br>
>> > the pgpool_config.c.<br>
<br>
</span>Generating pgpool_config.c is intentionally disabled. But since we are<br>
in a development phase so we can enable it until code freeze of<br>
3.7. What do you think?<br>
<br>
Just changing AM_MAINTAINER_MODE(disable) to<br>
AM_MAINTAINER_MODE(enable) in <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> will make it.<br></blockquote><div><br></div>Yes I think we can enable it in master branch only, and save us from such surprises :-)</div><div class="gmail_quote"><br></div><div class="gmail_quote">Best Regards,</div><div class="gmail_quote">Muhammad Usama</div><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
</div></div></blockquote></div><br></div></div>