<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 20, 2017 at 5:49 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In this implementation, I have removed "failback to template1 database<br>
if postgres database does not exist while doing health check"<br>
feature. The reasons are:<br>
<br>
- It is pretty rare that the database postgres does not exist.<br>
- Even if the case, user can specify alternate database.<br>
- The failback feature makes the code complex and reduces maintainability<br>
and reliability.<br>
<br>
For now, the code works as follows:<br>
<br>
- If health check database is specified, use it.<br>
<br>
- If health check database is not specified (i.e. empty), use postgres<br>
database instead.<br>
<br>
If there's no objection, I would like to go forward this way (no<br>
failback feature).<br></blockquote><div><br></div><div>I think this totally make sense to remove the tailback to template1 database for health check, Since the health check database is configurable so there is no point in failing back to template1 db.</div><div><br></div><div>Kind Regards</div><div>Muhammad Usama</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
<div><div class="h5"><br>
> Implement infrastructure for supporting per node health check parameters.<br>
><br>
> Now pgpool main process forks health check process for each DB node.<br>
> Also autotools is now updated from 1.14 to 1.15.<br>
><br>
> TODO:<br>
> - Implement per node health check parameters.<br>
><br>
> Branch<br>
> ------<br>
> master<br>
><br>
> Details<br>
> -------<br>
> <a href="https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=127e64fa52fe2ad2337eea5d55a0b8104f0a4df6" rel="noreferrer" target="_blank">https://git.postgresql.org/<wbr>gitweb?p=pgpool2.git;a=<wbr>commitdiff;h=<wbr>127e64fa52fe2ad2337eea5d55a0b8<wbr>104f0a4df6</a><br>
><br>
> Modified Files<br>
> --------------<br>
> Makefile.in | 49 +++--<br>
> aclocal.m4 | 71 ++++----<br>
> configure | 85 +++++----<br>
> doc.ja/Makefile.in | 24 ++-<br>
> doc.ja/src/Makefile.in | 24 ++-<br>
> doc.ja/src/sgml/Makefile.in | 24 ++-<br>
> doc/Makefile.in | 24 ++-<br>
> doc/src/Makefile.in | 24 ++-<br>
> doc/src/sgml/Makefile.in | 24 ++-<br>
> src/Makefile.am | 1 +<br>
> src/Makefile.in | 34 +++-<br>
> src/include/Makefile.in | 25 ++-<br>
> src/include/pool.h | 4 +-<br>
> src/libs/Makefile.in | 24 ++-<br>
> src/libs/pcp/Makefile.in | 27 ++-<br>
> src/main/health_check.c | 352 ++++++++++++++++++++++++++++++<wbr>++++++<br>
> src/main/pgpool_main.c | 247 +++++--------------------<br>
> src/parser/Makefile.in | 26 ++-<br>
> src/protocol/pool_connection_<wbr>pool.c | 17 +-<br>
> src/tools/Makefile.in | 25 ++-<br>
> src/tools/pcp/Makefile.in | 25 ++-<br>
> src/tools/pgmd5/Makefile.in | 26 ++-<br>
> src/watchdog/Makefile.in | 25 ++-<br>
> 23 files changed, 815 insertions(+), 392 deletions(-)<br>
><br>
</div></div>______________________________<wbr>_________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/<wbr>listinfo/pgpool-hackers</a><br>
</blockquote></div><br></div></div>