<div dir="ltr">Hi Ishii-San<div><br></div><div>Thanks for your input. It appears that the problem was caused by my commit :-( </div><div>I have pushed the fixes.</div><div><br></div><div><a href="http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=680e3297f1d6c58810889ccf54a0614617739e7b" rel="noreferrer" target="_blank" style="font-size:12.8px">http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=680e3297f1d6c58810889ccf54a0614617739e7b</a><div class="" style="margin:2px 0px 0px;font-size:12.8px"></div><div><div class="gmail_extra"><br></div><div class="gmail_extra">Regards</div><div class="gmail_extra">Muhammad Usama</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 14, 2016 at 10:12 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">[Subject changed due to different topic]<br>
<br>
PCP's_socket_dir has been there until pgpool-II 3.4.<br>
<br>
>From pgpool-II 3.5 it was removed by this commit:<br>
<br>
<a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=e95c05b06283ec4c801f3ecd0f1d182ca10913cd" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=e95c05b06283ec4c801f3ecd0f1d182ca10913cd</a><br>
<br>
My guess is, this was just a mistake.<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
> Hello, pgpool-hackers<br>
><br>
> There are no code to handle "pcp_socket_dir" in<br>
> src/config/pool_config.l:pool_get_config() of pgpool-II 3.5.3,<br>
> but the code to handle "socket_dir" appears twice.<br>
><br>
> regards,<br>
> TAKATSUKA Haruka / harukat @ <a href="http://sraoss.co.jp" rel="noreferrer" target="_blank">sraoss.co.jp</a><br>
><br>
><br>
> On Thu, 14 Jul 2016 07:59:20 +0900 (JST)<br>
> Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
><br>
>> pcp_listen_addresses was added by this commit toward pgpool-II 3.4 on 2014/04/10:<br>
>><br>
>> <a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=d87e2706b88558321b2ad287374149d5ba15c3af" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=d87e2706b88558321b2ad287374149d5ba15c3af</a><br>
>><br>
>> The particlular potion of the code to handle pcp_listen_addresses is in src/main/main.c:<br>
>><br>
>> diff --git a/src/main/main.c b/src/main/main.c<br>
>> index b826dea..027bdb4 100644 (file)<br>
>> --- a/src/main/main.c<br>
>> +++ b/src/main/main.c<br>
>> @@ -654,8 +654,11 @@ int main(int argc, char **argv)<br>
>><br>
>> /* fork a child for PCP handling */<br>
>> pcp_unix_fd = create_unix_domain_socket(pcp_un_addr);<br>
>> - /* maybe change "*" to pool_config->pcp_listen_addresses */<br>
>> - pcp_inet_fd = create_inet_domain_socket("*", pool_config->pcp_port);<br>
>> +<br>
>> + if (pool_config->pcp_listen_addresses[0])<br>
>> + {<br>
>> + pcp_inet_fd = create_inet_domain_socket(pool_config->pcp_listen_addresses, pool_config->pcp_port);<br>
>> + }<br>
>> pcp_pid = pcp_fork_a_child(pcp_unix_fd, pcp_inet_fd, pcp_conf_file);<br>
>><br>
>> /* Fork worker process */<br>
>><br>
>> Then removed by this commit on 2014/04/28:<br>
>><br>
>> <a href="https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=cdb49d3b783c03a7394e191e86763f364c7c6ce6" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=cdb49d3b783c03a7394e191e86763f364c7c6ce6</a><br>
>><br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> > Hi Ishii-San<br>
>> > While looking at the code for this bug report I found out that pgpool<br>
>> > always bind the PCP listening socket to all addresses and ignore<br>
>> > "pcp_listen_addresses" configuration<br>
>> ><br>
>> > Snippet of related code in file:pgpool_main.c<br>
>> ><br>
>> > /* maybe change "*" to pool_config->pcp_listen_addresses */<br>
>> > pcp_inet_fd = create_inet_domain_socket("*", pool_config->pcp_port);<br>
>> ><br>
>> > Do you remember any particular reason for that? Since this code same since<br>
>> > the very beginning<br>
>> ><br>
>> ><br>
>> > Regards<br>
>> > Muhamamd Usama<br>
>> ><br>
>> ><br>
>> > On Wed, Jul 13, 2016 at 6:46 AM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
>> ><br>
>> >> Usama,<br>
>> >><br>
>> >> Recently an issue regarding pcp command has been posted to our<br>
>> >> official pgpool-II mirror at GitHub. Can you please take a look at<br>
>> >> it?<br>
>> >><br>
>> >> <a href="https://github.com/pgpool/pgpool2/issues/4" rel="noreferrer" target="_blank">https://github.com/pgpool/pgpool2/issues/4</a><br>
>> >> --<br>
>> >> Tatsuo Ishii<br>
>> >> SRA OSS, Inc. Japan<br>
>> >> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> >> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
>> >><br>
>> >> From: Zachary Sheets <<a href="mailto:notifications@github.com">notifications@github.com</a>><br>
>> >> Subject: [pgpool/pgpool2] [v3.5.3] PCP options from pgpool.conf not being<br>
>> >> used (#4)<br>
>> >> Date: Tue, 12 Jul 2016 12:38:17 -0700<br>
>> >> Message-ID: <pgpool/pgpool2/issues/<a href="mailto:4@github.com">4@github.com</a>><br>
>> >><br>
>> >> > OS: ArchLinux<br>
>> >> > Kernel: 4.6.4-GrSec<br>
>> >> > PgSQL: 9.5.3<br>
>> >> > PgPool-II: 3.5.3<br>
>> >> ><br>
>> >> > Compile-time options:<br>
>> >> > ``` bash<br>
>> >> > ./configure \<br>
>> >> > --prefix=/usr \<br>
>> >> > --with-openssl \<br>
>> >> > --sysconfdir=/etc/pgpool \<br>
>> >> > --mandir=/usr/share/man<br>
>> >> > ```<br>
>> >> ><br>
>> >> > pgpool.conf (relevant options):<br>
>> >> > ``` bash<br>
>> >> > # ...<br>
>> >> > socket_dir = '/run/postgresql'<br>
>> >> > # ...<br>
>> >> > pcp_listen_addresses = ''<br>
>> >> > pcp_port = 9090<br>
>> >> > pcp_socket_dir = '/run/postgresql'<br>
>> >> > # ...<br>
>> >> > wd_ipc_socket_dir = '/run/postgresql'<br>
>> >> > # ...<br>
>> >> > ```<br>
>> >> ><br>
>> >> > This file should be in ```/run/postgresql```, not in ```/tmp```:<br>
>> >> > ``` bash<br>
>> >> > # ls -lAt /tmp<br>
>> >> > total 0<br>
>> >> > srwxrwxrwx 1 root root 0 Jul 12 15:17 .s.PGSQL.9090<br>
>> >> > ```<br>
>> >> ><br>
>> >> > The PCP service should not be listening on *any* address, let alone<br>
>> >> *every* address.<br>
>> >> > ``` bash<br>
>> >> > # ss -lnt | grep ':9090'<br>
>> >> > LISTEN 0 48 *:9090 *:*<br>
>> >> > ```<br>
>> >> ><br>
>> >> > The ```pcp_pool_status``` tool is, according to documentation, supposed<br>
>> >> to be using the same ```pgpool.conf``` file as the main service. It either<br>
>> >> is not, or has its values hardcoded. No option is listed in the<br>
>> >> documentation to use a specific configuration file.<br>
>> >> > ``` bash<br>
>> >> > # pcp_pool_status -U <user><br>
>> >> > ERROR: connection to socket "/tmp/.s.PGSQL.9898" failed with error "No<br>
>> >> such file or directory"<br>
>> >> > ```<br>
>> >> ><br>
>> >> > ---<br>
>> >> > You are receiving this because you are subscribed to this thread.<br>
>> >> > Reply to this email directly or view it on GitHub:<br>
>> >> > <a href="https://github.com/pgpool/pgpool2/issues/4" rel="noreferrer" target="_blank">https://github.com/pgpool/pgpool2/issues/4</a><br>
>> >> _______________________________________________<br>
><br>
> _______________________________________________<br>
> pgpool-hackers mailing list<br>
> <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</blockquote></div><br></div></div></div></div>