<div dir="ltr">Hi Yugo<div><br></div><div>Thanks for the patch. It solves the issue perfectly.</div><div>I have committed it to master branch.</div><div><a href="http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=7bcc2a438f305eb8683336515f07b98c7e96ace7" rel="noreferrer" target="_blank" style="font-size:12.8px">http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=7bcc2a438f305eb8683336515f07b98c7e96ace7</a><br></div><div><br></div><div>Regards</div><div>Muhammad Usama</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 4, 2016 at 8:01 AM, Yugo Nagata <span dir="ltr"><<a href="mailto:nagata@sraoss.co.jp" target="_blank">nagata@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Usama,<br>
<br>
What do you think about the attached patch?<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, 29 Dec 2015 03:37:27 +0500<br>
Muhammad Usama <<a href="mailto:m.usama@gmail.com">m.usama@gmail.com</a>> wrote:<br>
<br>
> Hi Yugo<br>
><br>
> Yes, correct. Sorry I forgot to reply back on the thread.<br>
><br>
> Thanks<br>
> Regards<br>
> Muhammad Usama<br>
><br>
> On Mon, Dec 28, 2015 at 11:03 AM, Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>> wrote:<br>
><br>
> > Hi Usama,<br>
> ><br>
> > Although there is no comment from you, I believe the following commit<br>
> > is the response to fix this.<br>
> ><br>
> > <a href="http://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=7f752d7606f758c5959dc91bb96346bef11de6e4;hp=8038107d8e1b0d7eb665255c11384c1a6386b94a" rel="noreferrer" target="_blank">http://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff;h=7f752d7606f758c5959dc91bb96346bef11de6e4;hp=8038107d8e1b0d7eb665255c11384c1a6386b94a</a><br>
> ><br>
> > However, unfortunately this problem is not resolved, since SIGCHLD<br>
> > handeler is<br>
> > not set before watchdog process is forked and pgpool waits watchdeog firing<br>
> > SIGUSR2 at sigsuspend forever.<br>
> ><br>
> > Please find the attached patch to fix this. This set SIGCHLD handler before<br>
> > initialize_watchdog() and if this fails with FATAL and exits, reaper() will<br>
> > handle this and pgpool will be shutdown successfully.<br>
> ><br>
> > Regards,<br>
> ><br>
> > On Mon, 21 Dec 2015 19:22:44 +0900<br>
> > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>> wrote:<br>
> ><br>
> > > Usama,<br>
> > ><br>
> > > When watchdog ADD request is rejected due to configuration inconsistency,<br>
> > > the FATAL error occurs at the rejected watchdog.<br>
> > ><br>
> > > FATAL: Add to watchdog cluster request is rejected by node<br>
> > "localhost:9000"<br>
> > ><br>
> > > However, after that, the pgpool-II parent process remains but any<br>
> > children<br>
> > > are not forked. I can't terminate pgpool by `pgpool stop` but we have to<br>
> > > use kill command.<br>
> > ><br>
> > > I think pgpool-II should fail to start and be terminated cleanly in<br>
> > > this situation.<br>
> > ><br>
> > > --<br>
> > > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
> > > _______________________________________________<br>
> > > pgpool-hackers mailing list<br>
> > > <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> > > <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
> ><br>
> ><br>
> > --<br>
> > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
> ><br>
> > _______________________________________________<br>
> > pgpool-hackers mailing list<br>
> > <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> > <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
> ><br>
> ><br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
</font></span></blockquote></div><br></div>