<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 4, 2016 at 10:16 AM, Yugo Nagata <span dir="ltr"><<a href="mailto:nagata@sraoss.co.jp" target="_blank">nagata@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Usama,<br>
<span class=""><br>
On Tue, 29 Dec 2015 03:32:00 +0500<br>
Muhammad Usama <<a href="mailto:m.usama@gmail.com">m.usama@gmail.com</a>> wrote:<br>
<br>
> Hi Yugo<br>
><br>
> Many thanks for the patch. Although the patch takes care of zombie<br>
> processes, but I think blocking the watchdog process at time of escalation<br>
> and de-escalation might lead to some un-expected results, because at that<br>
> time when the watchdog process will be waiting for the<br>
> escalation/de-escalation process to finish it would not be replying to<br>
> other nodes.<br>
> So can you please have a look at the attached path which uses the SIGCHILD<br>
> to handle the zombie process problem<br>
<br>
</span>I have looked at and tested this and I think this is good to be committed.<br></blockquote><div><br></div><div>I have committed the patch to master branch</div><div><a href="http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=106681f4bf6a5ecb230716c33918a0d76c4cdcfc" rel="noreferrer" target="_blank" style="font-size:12.8px">http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=106681f4bf6a5ecb230716c33918a0d76c4cdcfc</a> </div><div><br></div><div>Best regards</div><div>Muhammad Usama</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
><br>
> Thanks<br>
> Best regards<br>
> Muhammad Usama<br>
><br>
> On Mon, Dec 28, 2015 at 2:11 PM, Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>> wrote:<br>
><br>
> > Hi Usama,<br>
> ><br>
> > I write the patch to fix it.<br>
> ><br>
> > In current, escalation process is forked but not waited by watchdog<br>
> > process. Fix is to wait the escalation process by waitpid. That is,<br>
> > watchdog is blocked while waiting the escalation finishing.<br>
> ><br>
> > Any comment?<br>
> ><br>
> > Regards,<br>
> ><br>
> > On Mon, 21 Dec 2015 16:46:33 +0900<br>
> > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>> wrote:<br>
> ><br>
> > > Usama,<br>
> > ><br>
> > > A zombie process appeared after pgpool started with watchdog.<br>
> > ><br>
> > > $ ps aux | grep pgpool<br>
> > > ...<br>
> > > yugo-n 32156 0.0 0.0 19880 1244 pts/27 S 16:31 0:00 pgpool:<br>
> > watchdog<br>
> > > yugo-n 32165 0.0 0.0 0 0 pts/27 Z 16:31 0:00<br>
> > [pgpool] <defunct><br>
> > > yugo-n 32166 0.0 0.0 17792 768 pts/27 S 16:31 0:00 pgpool:<br>
> > lifecheck<br>
> > > ...<br>
> > ><br>
> > > I found PID 32165 was pid of the escalation process.<br>
> > ><br>
> > > 2015-12-21 16:31:33: pid 32156: LOG: escalation process started with<br>
> > PID:32165<br>
> > > 2015-12-21 16:31:33: pid 32165: LOG: watchdog: escalation started<br>
> > ><br>
> > > I can reproduce this on Ubuntu but not CentOS.<br>
> > ><br>
> > > Regarads,<br>
> > > --<br>
> > > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
> > > _______________________________________________<br>
> > > pgpool-hackers mailing list<br>
> > > <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> > > <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
> ><br>
> ><br>
> > --<br>
> > Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
> ><br>
> > _______________________________________________<br>
> > pgpool-hackers mailing list<br>
> > <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> > <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
> ><br>
> ><br>
<br>
<br>
</div></div><span class=""><font color="#888888">--<br>
Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
</font></span></blockquote></div><br></div></div>